feat: read from errors field in apply items response body to display errors (#241)

Co-authored-by: Paola Nicosia <[email protected]>

Author: LiliumCandidum

internal/cmd/marketplace/apply/apply_test.go

@@ -334,20 +334,49 @@ func TestApplyPrintApplyOutcome(t *testing.T) {
 						},
 					},
 				},
+				{
+					ID:       "id5",
+					ItemID:   "item-id-5",
+					Done:     false,
+					Inserted: false,
+					Updated:  false,
+					ValidationErrors: []marketplace.ApplyResponseItemValidationError{
+						{
+							Message: "some validation error",
+						},
+					},
+					Errors: []marketplace.ApplyResponseItemValidationError{
+						{
+							Message: "some validation error in errors field",
+						},
+					},
+				},
+				{
+					ID:       "id6",
+					ItemID:   "item-id-6",
+					Done:     true,
+					Inserted: true,
+					Updated:  false,
+				},
 			},
 		}
 		found := buildOutcomeSummaryAsTables(mockOutcome)
-		require.Contains(t, found, "3 of 4 items have been successfully applied:")
+		require.Contains(t, found, "4 of 6 items have been successfully applied:")
 		require.Contains(t, found, "id1")
 		require.Contains(t, found, "item-id-1")
 		require.Contains(t, found, "id2")
 		require.Contains(t, found, "item-id-2")
 		require.Contains(t, found, "id3")
 		require.Contains(t, found, "item-id-3")
-		require.Contains(t, found, "1 of 4 items have not been applied due to validation errors:")
+		require.Contains(t, found, "id6")
+		require.Contains(t, found, "item-id-6")
+		require.Contains(t, found, "2 of 6 items have not been applied due to validation errors:")
 		require.Contains(t, found, "id4")
 		require.Contains(t, found, "item-id-4")
 		require.Contains(t, found, "some validation error")
+		require.Contains(t, found, "id5")
+		require.Contains(t, found, "item-id-5")
+		require.Contains(t, found, "some validation error in errors field")
 		require.Contains(t, found, "OBJECT ID")
 		require.Contains(t, found, "ITEM ID")
 	})

internal/cmd/marketplace/apply/table.go

@@ -60,7 +60,12 @@ func buildFailureTable(items []marketplace.ApplyResponseItem) string {
 	headers := []string{"Object ID", "Item ID", "Validation Errors"}
 	columnTransform := func(item marketplace.ApplyResponseItem) []string {
 		var validationErrorsStr string
-		validationErrors := item.ValidationErrors
+		var validationErrors []marketplace.ApplyResponseItemValidationError
+		if len(item.Errors) > 0 {
+			validationErrors = item.Errors
+		} else {
+			validationErrors = item.ValidationErrors
+		}
 		for i, valErr := range validationErrors {
 			validationErrorsStr += valErr.Message
 			if len(validationErrors)-1 > i {

internal/resources/marketplace/marketplace.go

@@ -46,6 +46,7 @@ type ApplyResponseItem struct {
 	Updated  bool `json:"updated"`
 
 	ValidationErrors []ApplyResponseItemValidationError `json:"validationErrors"`
+	Errors           []ApplyResponseItemValidationError `json:"errors"`
 }
 
 type ApplyResponseItemValidationError struct {