Fix tests for failed deploy pipeline

Author: Fabio Stabile

internal/cmd/deploy/trigger_test.go

@@ -41,6 +41,11 @@ func TestDeploy(t *testing.T) {
 			server:    testTriggerServer(t),
 			projectID: "correct",
 		},
+		"pipeline failed": {
+			server:    testFailedTriggerServer(t),
+			projectID: "failed",
+			expectErr: true,
+		},
 		"pipeline fails": {
 			server:    testTriggerServer(t),
 			projectID: "fails-bad-request",
@@ -97,13 +102,6 @@ func testTriggerServer(t *testing.T) *httptest.Server {
 			})
 			require.NoError(t, err)
 			w.Write(data)
-		case r.Method == http.MethodGet && r.URL.Path == fmt.Sprintf(pipelineStatusEndpointTemplate, "failed", 1) && r.URL.Query().Get("environment") == "environmentName":
-			data, err := resources.EncodeResourceToJSON(&resources.PipelineStatus{
-				ID:     1,
-				Status: "failed",
-			})
-			require.NoError(t, err)
-			w.Write(data)
 		case r.Method == http.MethodPost && r.URL.Path == fmt.Sprintf(deployProjectEndpointTemplate, "fails-bad-request"):
 			respBody := `{"error": "Bad Request","message":"some bad request"}`
 
@@ -122,3 +120,32 @@ func testTriggerServer(t *testing.T) *httptest.Server {
 
 	return server
 }
+
+func testFailedTriggerServer(t *testing.T) *httptest.Server {
+	t.Helper()
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		t.Helper()
+		switch {
+		case r.Method == http.MethodPost && r.URL.Path == fmt.Sprintf(deployProjectEndpointTemplate, "failed"):
+			data, err := resources.EncodeResourceToJSON(&resources.DeployProject{
+				ID:  1,
+				URL: "http://example.com",
+			})
+
+			require.NoError(t, err)
+			w.Write(data)
+		case r.Method == http.MethodGet && r.URL.Path == fmt.Sprintf(pipelineStatusEndpointTemplate, "failed", 1) && r.URL.Query().Get("environment") == "environmentName":
+			data, err := resources.EncodeResourceToJSON(&resources.PipelineStatus{
+				ID:     1,
+				Status: "failed",
+			})
+			require.NoError(t, err)
+			w.Write(data)
+		default:
+			w.WriteHeader(http.StatusNotFound)
+			require.FailNowf(t, "unknown http request", "request method: %s request URL: %s", r.Method, r.URL)
+		}
+	}))
+
+	return server
+}