Merge pull request #258 from miantiao-me/copilot/fix-password-removal-issue

fix: allow removing a password from a link on edit

Author: miantiao-me

server/api/link/edit.put.ts

@@ -58,6 +58,9 @@ export default eventHandler(async (event) => {
     createdAt: existingLink.createdAt,
     updatedAt: Math.floor(Date.now() / 1000),
   }
+  if (link.password === undefined) {
+    delete newLink.password
+  }
   await putLink(event, newLink)
   setResponseStatus(event, 201)
   const shortLink = buildShortLink(event, newLink.slug)

tests/api/link.spec.ts

@@ -175,6 +175,22 @@ describe.sequential('/api/link/edit', () => {
     expect(data).toHaveProperty('shortLink')
   })
 
+  it('removes password when not provided in edit', async () => {
+    const slug = testLinkPayload.slug
+
+    // Set a password on the link
+    const setPasswordResponse = await putJson('/api/link/edit', { ...testLinkPayload, password: 'secret123' })
+    expect(setPasswordResponse.status).toBe(201)
+    const setData = await setPasswordResponse.json() as { link: { password?: string } }
+    expect(setData.link.password).toBe('secret123')
+
+    // Edit the link without providing a password (user cleared the field)
+    const removePasswordResponse = await putJson('/api/link/edit', { url: testLinkPayload.url, slug })
+    expect(removePasswordResponse.status).toBe(201)
+    const removeData = await removePasswordResponse.json() as { link: { password?: string } }
+    expect(removeData.link.password).toBeUndefined()
+  })
+
   it('returns 404 when editing non-existent link', async () => {
     const payload = { url: 'https://example.com', slug: 'non-existent-slug-for-edit-12345' }
     const response = await putJson('/api/link/edit', payload)