fix: enhance device redirection logic and add tests for CriOS user agent #274

Author: miantiao-me

server/middleware/1.redirect.ts

@@ -19,6 +19,8 @@ const SOCIAL_BOTS = [
   'whatsapp',
 ]
 
+const APPLE_DEVICE_UA_MARKERS = ['iphone', 'ipad', 'ipod', 'crios']
+
 function isSocialBot(userAgent: string): boolean {
   const ua = userAgent.toLowerCase()
   return SOCIAL_BOTS.some(bot => ua.includes(bot))
@@ -34,7 +36,7 @@ function getDeviceRedirectUrl(userAgent: string, link: Link): string | null {
     return link.google
   }
 
-  if (link.apple && (ua.includes('iphone') || ua.includes('ipad') || ua.includes('ipod'))) {
+  if (link.apple && APPLE_DEVICE_UA_MARKERS.some(marker => ua.includes(marker))) {
     return link.apple
   }
 

tests/sink.spec.ts

@@ -1,9 +1,33 @@
 import { describe, expect, it } from 'vitest'
-import { fetch } from './utils'
+import { fetch, postJson } from './utils'
 
 describe('/', () => {
   it('returns 200 for homepage request', async () => {
     const response = await fetch('/')
     expect(response.status).toBe(200)
   })
+
+  it('redirects CriOS user agent to apple URL', async () => {
+    const slug = `crios-apple-${crypto.randomUUID()}`
+    const apple = 'https://apps.apple.com/app/sink-test'
+
+    const createResponse = await postJson('/api/link/create', {
+      url: 'https://example.com',
+      slug,
+      apple,
+    })
+    expect(createResponse.status).toBe(201)
+    const createData = await createResponse.json() as { link: { apple?: string } }
+    expect(createData.link.apple).toBe(apple)
+
+    const response = await fetch(`/${slug}`, {
+      redirect: 'manual',
+      headers: {
+        'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/147 Version/11.1.1 Safari/605.1.15',
+      },
+    })
+
+    expect(response.status).toBe(301)
+    expect(response.headers.get('Location')).toBe(apple)
+  })
 })