expected float as value got "" on smartmon_avg_write_erase_count_raw_value

[rummens]

Hi there,

first of all, thank you very much for this great script and the work you put into this. I just deployed the script and setup my NodeExporter to scape it (I am running Microshift on RHEL9 if that helps). The script runs on the OS and the NodeExporter scrapes it from within its container, as it has a mount of the filesystem. This seems to work.

The error I can see in the logs is the following:

ts=2024-12-14T10:14:30.208Z caller=textfile.go:245 level=error collector=textfile msg="failed to collect textfile data" file=smart_metrics.prom err="failed to parse textfile data from \"/host/root/var/lib/node_ex │
│ porter/textfile_collector/smart_metrics.prom\": text format parsing error in line 12: expected float as value, got \"\""

And indeed if checking the file, line 12 shows an empty value:
smartmon_avg_write_erase_count_raw_value{disk="/dev/sdc",type="sat",smart_id="173"}

I did try to enable the special seagate flag, eventhough I do have WD drives but figured I should try every combination. Unfortunately this did not change things:
smartmon_device_info{disk="/dev/sda",type="sat",model_family="Western Digital Red",model_name="WDC WD40EFRX-68WT0N0",device_model="",serial_number="WD-XXX",firmware_version="82.00A82",vendor="",product="",revision="",lun_id=""} 1

Could you point me in any directions? Thanks a lot!
Marcel

[rummens]

So I did a bit more digging and it seems the issue is with one my disks. For some reason /dev/sdc is reporting no threshold figures. Now I am not expert enough with S.M.A.R.T. values to know what this means or where this might come up. I just reverse engineered the script to come to this conclusion. I suppose though that this value is kind of important or?

I thought about assigning a default value, if you think that makes sense? I am happy to contribute the code for that?

Background info

Here is an extract of what is returned from the smartctl -A -j -d sat /dev/sdc command analysed in the function parse_smartctl_attributes_json. The thres value is clear missing:

{
        "id": 173,
        "name": "Avg_Write/Erase_Count",
        "value": 100,
        "worst": 100,
        "flags": {
          "value": 50,
          "string": "-O--CK ",
          "prefailure": false,
          "updated_online": true,
          "performance": false,
          "error_rate": false,
          "event_count": true,
          "auto_keep": true
        },
        "raw": {
          "value": 3,
          "string": "3"
        }
      }

Which leads to the tsv table created in the same function looking like this. The raw value (which is reported back) falls over into the threshold column (which also is probably not intended) and the raw_value column remains empty as a result (which ultimately results in the behaviour I described originally):

5	Reallocated_Sector_Ct	100	100		0
9	Power_On_Hours	100	100		7191
12	Power_Cycle_Count	100	100		258
165	Total_Write/Erase_Count	100	100		8631550427
166	Min_W/E_Cycle	100	100		3
167	Min_Bad_Block/Die	100	100		146
168	Maximum_Erase_Cycle	100	100		5
169	Total_Bad_Block	100	100		1245
170	Unknown_Marvell_Attr	100	100		0
171	Program_Fail_Count	100	100		0
172	Erase_Fail_Count	100	100		0
173	Avg_Write/Erase_Count	100	100		3
174	Unexpect_Power_Loss_Ct	100	100		41
184	End_to_End_Error	100	100		0
187	Reported_Uncorrect	100	100		0
188	Command_Timeout	100	100		0
194	Temperature_Celsius	67	43		33
199	SATA_CRC_Error	100	100		0
230	Perc_Write/Erase_Count	1	1		95
232	Perc_Avail_Resrvd_Space	100	100	4	100
233	Total_NAND_Writes_GiB	100	100		6268
234	Perc_Write/Erase_Ct_BC	100	100		10590
241	Total_Writes_GiB	253	253		9783
242	Total_Reads_GiB	253	253		6584
244	Thermal_Throttle	0	100		0

More details about this disk (I mixed them up earlier, its my sandisk flash cache disk and not my WD HDDs):

smartctl -i -j /dev/sdc
{
  "json_format_version": [
    1,
    0
  ],
  "smartctl": {
    "version": [
      7,
      2
    ],
    "svn_revision": "5155",
    "platform_info": "x86_64-linux-5.14.0-427.33.1.el9_4.x86_64",
    "build_info": "(local build)",
    "argv": [
      "smartctl",
      "-i",
      "-j",
      "/dev/sdc"
    ],
    "exit_status": 0
  },
  "device": {
    "name": "/dev/sdc",
    "info_name": "/dev/sdc [SAT]",
    "type": "sat",
    "protocol": "ATA"
  },
  "model_family": "Marvell based SanDisk SSDs",
  "model_name": "SanDisk SDSSDH3 2T00",
  "serial_number": "XXX",
  "wwn": {
    "naa": 5,
    "oui": 6980,
    "id": 19998322914
  },
  "firmware_version": "415020RL",
  "user_capacity": {
    "blocks": 3907029168,
    "bytes": 2000398934016
  },
  "logical_block_size": 512,
  "physical_block_size": 512,
  "rotation_rate": 0,
  "form_factor": {
    "ata_value": 3,
    "name": "2.5 inches"
  },
  "trim": {
    "supported": true,
    "deterministic": true,
    "zeroed": true
  },
  "in_smartctl_database": true,
  "ata_version": {
    "string": "ACS-4 T13/BSR INCITS 529 revision 5",
    "major_value": 4080,
    "minor_value": 94
  },
  "sata_version": {
    "string": "SATA 3.3",
    "value": 511
  },
  "interface_speed": {
    "max": {
      "sata_value": 14,
      "string": "6.0 Gb/s",
      "units_per_second": 60,
      "bits_per_unit": 100000000
    },
    "current": {
      "sata_value": 3,
      "string": "6.0 Gb/s",
      "units_per_second": 60,
      "bits_per_unit": 100000000
    }
  },
  "local_time": {
    "time_t": 1734182868,
    "asctime": "Sat Dec 14 14:27:48 2024 CET"
  }
}

[micha37-martins]

Thanks for your report. As this seems to be a valid issue with some disk feel free to contribute to the code :)