Add more validation to data read from the cache

see https://forums.slimdevices.com/forum/user-forums/logitech-media-server/1742419

Author: michaelherger

API.pm

@@ -114,6 +114,8 @@ sub getImageUrl {
 sub typeOfItem {
 	my ($class, $item) = @_;
 
+	return '' unless ref $item;
+
 	if ( $item->{type} && $item->{type} =~ /(?:EXTURL|VIDEO)/ ) {}
 	elsif ( defined $item->{hasPlaylists} && $item->{path} ) {
 		return 'category';
@@ -153,7 +155,9 @@ sub cacheTrackMetadata {
 		my $entry = $_;
 		$entry = $entry->{item} if $entry->{item};
 
-		my $oldMeta = $cache->get( 'tidal_meta_' . $entry->{id}) || {};
+		my $oldMeta = $cache->get( 'tidal_meta_' . $entry->{id});
+		$oldMeta = {} unless ref $oldMeta;
+
 		my $icon = $class->getImageUrl($entry, 'usePlaceholder', 'track');
 		my $artist = $entry->{artist};
 		($artist) = grep { $_->{type} eq 'MAIN'} @{$entry->{artists}} unless $artist;

API/Async.pm

@@ -455,7 +455,7 @@ sub getFavorites {
 
 	# use cached data unless the collection has changed
 	my $cached = $cache->get($cacheKey);
-	if ($cached && ref $cached->{items}) {
+	if (ref $cached && ref $cached->{items}) {
 		# don't bother verifying timestamp unless we're sure we need to
 		return $cb->($cached->{items}) unless $refresh;
 
@@ -517,7 +517,7 @@ sub getCollectionPlaylists {
 	};
 
 	my $cached = $cache->get($cacheKey);
-	if ($cached && ref $cached->{items}) {
+	if (ref $cached && ref $cached->{items}) {
 		return $cb->($cached->{items}) unless $refresh;
 
 		$self->getLatestCollectionTimestamp(sub {

Importer.pm

@@ -70,7 +70,7 @@ sub scanAlbums { if (main::SCANNER) {
 		foreach my $album (@$albums) {
 			my $albumDetails = $cache->get('tidal_album_with_tracks_' . $album->{id});
 
-			if ( $albumDetails && $albumDetails->{tracks} && ref $albumDetails->{tracks}) {
+			if ( ref $albumDetails && $albumDetails->{tracks} && ref $albumDetails->{tracks}) {
 				$progress->update($album->{title});
 
 				$class->storeTracks([

InfoMenu.pm

@@ -439,7 +439,7 @@ sub _menuTrackInfo {
 
 	# if we are here, the metadata of the track is cached
 	my $track = $cache->get("tidal_meta_$id");
-	$log->error("metadata not cached for $id") && return [] unless $track;
+	$log->error("metadata not cached for $id") && return [] unless $track && ref $track;
 
 	# play/add/add_next options except for skins that don't want it
 	my $base = _menuBase($api->client, 'track', $id, $params);

ProtocolHandler.pm

@@ -63,7 +63,7 @@ sub trackGain {
 	my $trackId = getId($url);
 	my $meta = $cache->get( 'tidal_meta_' . ($trackId || '') );
 
-	return unless $meta && defined $meta->{replay_gain} && defined $meta->{peak};
+	return unless ref $meta && defined $meta->{replay_gain} && defined $meta->{peak};
 
 	# TODO - try to get album gain information?
 
@@ -260,7 +260,7 @@ sub getMetadataFor {
 	my $meta = $cache->get( 'tidal_meta_' . ($trackId || '') );
 
 	# if metadata is in cache, we just need to add bitrate
-	if ($meta) {
+	if (ref $meta) {
 		# TODO - remove if we decide to move to our own cache file which we can version
 		$meta->{artist} = $meta->{artist}->{name} if ref $meta->{artist};