fix(cases-analytics-v2): gate cases-templates SO references behind templates.enabled

`xpack.cases.templates.enabled` defaults to false. When it's off, the
`cases-templates` SO type is not registered with core (see
saved_object_types/index.ts). The v2 internal repository was naming
`CASE_TEMPLATE_SAVED_OBJECT` unconditionally whenever v2 was on, so
`createInternalRepository` threw "Missing mappings for saved objects
types: 'cases-templates'" on boot and Kibana never came up. This is
the exact failure mode `config_analytics_v2.ts` (FTR config with v2
on / templates off) triggers, and the latent production crash for
any customer enabling v2 without templates.

Mirrors the cases-attachments gating pattern from PR3:

- plugin.ts: pass templatesEnabled to CasesAnalyticsV2Service and
  conditionally spread CASE_TEMPLATE_SAVED_OBJECT into the v2 internal
  repository via the same flag. Comment block on the repo opt-in
  expanded to document the gate.
- cases_analytics_v2/service.ts: thread templatesEnabled through to
  CasesAnalyticsV2DataViewService at start.
- cases_analytics_v2/data_view/service.ts: collectSnakeKeysForSpace
  short-circuits to [] when templatesEnabled is false. Per-space data
  views still bootstrap, with an empty runtime field overlay — the
  correct shape when there are no templates to project.
- service.test.ts / data_view/service.test.ts: fixture updates plus a
  new regression test asserting the internal SO client is never
  queried for cases-templates when the flag is off.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: michaelolo24

x-pack/platform/plugins/shared/cases/server/cases_analytics_v2/data_view/service.test.ts

@@ -35,7 +35,10 @@ describe('CasesAnalyticsV2DataViewService', () => {
    * and returns the deps any test needs to call `ensureForSpace` /
    * `refreshForSpace`.
    */
-  const setup = (templates: Array<SavedObject<TemplateLike>> = []) => {
+  const setup = (
+    templates: Array<SavedObject<TemplateLike>> = [],
+    { templatesEnabled = true }: { templatesEnabled?: boolean } = {}
+  ) => {
     const internalSoClient = savedObjectsClientMock.create();
     stubFindOnePage(internalSoClient, templates);
 
@@ -47,6 +50,7 @@ describe('CasesAnalyticsV2DataViewService', () => {
       logger,
       dataViewsService,
       internalSavedObjectsClient: internalSoClient,
+      templatesEnabled,
     });
 
     return {
@@ -145,6 +149,35 @@ describe('CasesAnalyticsV2DataViewService', () => {
       expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining('cluster unavailable'));
     });
 
+    /**
+     * Regression guard for the "templates off → cases-templates SO type
+     * not registered" path. When `xpack.cases.templates.enabled` is
+     * false, `caseTemplateSavedObjectType` is not registered with core
+     * (see `saved_object_types/index.ts`), so the internal SO client
+     * would throw "Missing mappings for saved objects types:
+     * 'cases-templates'" on any `find({ type: CASE_TEMPLATE_SAVED_OBJECT })`
+     * call. The service must skip the template walk entirely in that
+     * configuration — never touching the SO client for templates — and
+     * bootstrap the per-space data view with an empty runtime field
+     * overlay (the base data view is still useful for ES|QL against
+     * the analytics index; only the extended-field projections are
+     * absent).
+     */
+    it('skips the cases-templates SO walk when templates feature flag is off', async () => {
+      const { service, dvService, internalSoClient, deps } = setup(
+        [makeTemplate('tpl-1', [{ name: 'risk', type: 'long', control: 'INPUT_NUMBER' }])],
+        { templatesEnabled: false }
+      );
+      stubMissingDataView(dvService);
+
+      await service.ensureForSpace(deps);
+
+      expect(internalSoClient.find).not.toHaveBeenCalled();
+      expect(dvService.createAndSave).toHaveBeenCalledTimes(1);
+      const [spec] = dvService.createAndSave.mock.calls[0];
+      expect(Object.keys(spec.runtimeFieldMap ?? {})).toEqual([]);
+    });
+
     /**
      * Two parallel cases requests in a fresh-cache space both pass the
      * cache check, both see `dvService.get` return 404, and both call
@@ -490,6 +523,7 @@ describe('CasesAnalyticsV2DataViewService', () => {
         logger: parentLogger,
         dataViewsService: makeDataViewsPluginStart(dvService),
         internalSavedObjectsClient: internalSoClient,
+        templatesEnabled: true,
       });
       // `logger.get('dataView')` is what the service holds for its
       // own log calls; the parent mock's `.get` returns a child mock

x-pack/platform/plugins/shared/cases/server/cases_analytics_v2/data_view/service.ts

@@ -58,12 +58,24 @@ interface CasesAnalyticsV2DataViewServiceDeps {
    * Internal (no-request) SO client used for template reads. Templates are
    * a hidden SO type, and the request-scoped client passed at ensure time
    * may not include them in `includedHiddenTypes`. The internal client is
-   * opted in to both `cases` and `cases-templates` at plugin start.
+   * opted in to both `cases` and `cases-templates` at plugin start —
+   * the latter only when `templatesEnabled` is true (see below).
    *
    * `namespaces: [spaceId]` on the find call scopes results to a single
    * space even though the client itself is unscoped.
    */
   internalSavedObjectsClient: SavedObjectsClientContract;
+  /**
+   * Resolved value of `xpack.cases.templates.enabled`. Gates the
+   * per-space `cases-templates` SO walk inside `collectSnakeKeysForSpace`.
+   * When false the SO type is not registered with core, so calling
+   * `internalSavedObjectsClient.find({ type: 'cases-templates' })` would
+   * throw "Missing mappings for saved objects types: 'cases-templates'";
+   * the walk short-circuits to an empty list and the data view is
+   * bootstrapped with no runtime field overlay (which is the correct
+   * shape when there are no templates to project).
+   */
+  templatesEnabled: boolean;
 }
 
 /**
@@ -427,6 +439,13 @@ export class CasesAnalyticsV2DataViewService {
    * version.
    */
   private async collectSnakeKeysForSpace(spaceId: string): Promise<string[]> {
+    // Templates feature flag is off — the `cases-templates` SO type is not
+    // registered with core, so naming it in `find({ type })` would throw
+    // "Missing mappings for saved objects types: 'cases-templates'".
+    // Returning empty here is also semantically correct: with no templates
+    // there are no extended fields to project as runtime fields.
+    if (!this.deps.templatesEnabled) return [];
+
     const out: string[] = [];
     let page = 1;
 

x-pack/platform/plugins/shared/cases/server/cases_analytics_v2/service.test.ts

@@ -26,6 +26,7 @@ describe('CasesAnalyticsV2Service', () => {
         enableAdminRoutes: false,
         resetTaskTimeoutMinutes: 60,
         resetPageDelayMs: 0,
+        templatesEnabled: true,
       });
       const proxy = service.getWriter();
 
@@ -56,6 +57,7 @@ describe('CasesAnalyticsV2Service', () => {
         enableAdminRoutes: false,
         resetTaskTimeoutMinutes: 60,
         resetPageDelayMs: 0,
+        templatesEnabled: true,
       });
       const refA = service.getDataViewRefresher();
       const refB = service.getDataViewRefresher();
@@ -72,6 +74,7 @@ describe('CasesAnalyticsV2Service', () => {
         enableAdminRoutes: false,
         resetTaskTimeoutMinutes: 60,
         resetPageDelayMs: 0,
+        templatesEnabled: true,
       });
       const refresher = service.getDataViewRefresher();
 

x-pack/platform/plugins/shared/cases/server/cases_analytics_v2/service.ts

@@ -66,6 +66,18 @@ interface CasesAnalyticsV2ServiceDeps {
    * periodic ticks always use 0 (no throttle).
    */
   resetPageDelayMs: number;
+  /**
+   * Resolved value of `xpack.cases.templates.enabled`. When false, the
+   * `cases-templates` SO type is not registered with core, so the data
+   * view sub-service must skip its per-space template read (otherwise
+   * the internal SO client throws "Missing mappings for saved objects
+   * types: 'cases-templates'"). Threaded through to the data view
+   * sub-service at `start()` time; per-space data views are still
+   * bootstrapped with an empty runtime field overlay when templates is
+   * off, which is the correct shape (no templates → no extended-field
+   * projections).
+   */
+  templatesEnabled: boolean;
 }
 
 /**
@@ -138,6 +150,7 @@ export class CasesAnalyticsV2Service {
   private readonly enableAdminRoutes: boolean;
   private readonly resetTaskTimeoutMinutes: number;
   private readonly resetPageDelayMs: number;
+  private readonly templatesEnabled: boolean;
   /**
    * Active writer. Starts as `V2_NOOP_WRITER` so calls before `start()`
    * (or when v2 is disabled) silently no-op. Replaced with a real
@@ -209,6 +222,7 @@ export class CasesAnalyticsV2Service {
     this.enableAdminRoutes = deps.enableAdminRoutes;
     this.resetTaskTimeoutMinutes = deps.resetTaskTimeoutMinutes;
     this.resetPageDelayMs = deps.resetPageDelayMs;
+    this.templatesEnabled = deps.templatesEnabled;
   }
 
   /**
@@ -368,6 +382,7 @@ export class CasesAnalyticsV2Service {
       logger: this.logger,
       dataViewsService: deps.dataViewsService,
       internalSavedObjectsClient: deps.internalSavedObjectsClient,
+      templatesEnabled: this.templatesEnabled,
     });
 
     // Schedule the singleton reconciliation task. Idempotent and safe

x-pack/platform/plugins/shared/cases/server/plugin.ts

@@ -160,6 +160,16 @@ export class CasePlugin
       // within budget without blocking the HTTP request.
       resetTaskTimeoutMinutes: this.caseConfig.analyticsV2.resetTaskTimeoutMinutes,
       resetPageDelayMs: this.caseConfig.analyticsV2.resetPageDelayMs,
+      // `xpack.cases.templates.enabled` gates whether `cases-templates`
+      // is registered with core (see `saved_object_types/index.ts`). The
+      // v2 data view sub-service reads template SOs to derive per-space
+      // runtime field overlays; if templates is off there are no SOs to
+      // read, and asking the SO client for the type would throw
+      // "Missing mappings for saved objects types: 'cases-templates'".
+      // Threading the flag through here lets the data view sub-service
+      // short-circuit to an empty runtime field map (the base data view
+      // is still bootstrapped — it just has no extended-field overlays).
+      templatesEnabled: this.caseConfig.templates?.enabled === true,
     });
     this.casesAnalyticsV2Service.setup({ core, taskManager: plugins.taskManager });
 
@@ -344,7 +354,15 @@ export class CasePlugin
         //    `cases-user-actions` SOs (created-only, no `updated_at`
         //    filter — see `reconciliation/activity_runner.ts`).
         //  - The data view sub-service reads `cases-templates` SOs per-space
-        //    to derive runtime fields.
+        //    to derive runtime fields. Only included when templates is on
+        //    — `cases-templates` is registered with core only when
+        //    `xpack.cases.templates.enabled` is true (see
+        //    `saved_object_types/index.ts`), and naming it here when the
+        //    mapping isn't registered throws "Missing mappings for saved
+        //    objects types: 'cases-templates'" from
+        //    `createInternalRepository`. With templates off, the data view
+        //    sub-service short-circuits its template read and bootstraps
+        //    per-space data views with an empty runtime field overlay.
         //  - The `/reset` admin route deletes per-space `index-pattern` SOs
         //    across namespaces. A request-scoped SO client can't do this:
         //    the spaces extension scopes `delete` to the request's namespace,
@@ -358,7 +376,7 @@ export class CasePlugin
         const v2InternalRepository = core.savedObjects.createInternalRepository([
           CASE_SAVED_OBJECT,
           CASE_USER_ACTION_SAVED_OBJECT,
-          CASE_TEMPLATE_SAVED_OBJECT,
+          ...(this.caseConfig.templates?.enabled ? [CASE_TEMPLATE_SAVED_OBJECT] : []),
           'index-pattern',
         ]);
         const v2InternalSavedObjectsClient = new SavedObjectsClient(v2InternalRepository);