fix: read cache.embeds alongside cache.links in typed_link and list_note

Obsidian stores `![[embed]]` links separately from `[[wikilink]]` links
in CachedMetadata (cache.embeds vs cache.links). Both the typed_link
Dataview-field parser and the list_note builder only read cache.links,
so an embedded wikilink used as a field value or list item silently
produced no edge. Refs #760

Author: michaelpporter

src/graph/builders/explicit/list_note.ts

@@ -51,7 +51,11 @@ function build_native_list_items(
 	section?: string,
 ): NativeListItem[] {
 	let list_item_caches = cache.listItems ?? [];
-	const links = cache.links ?? [];
+	// `[[wikilink]]` and `![[embed]]` land in separate cache arrays, but a list
+	// item's outlink can be either (e.g. `- ![[Note]]`).
+	const links = [...(cache.links ?? []), ...(cache.embeds ?? [])].sort(
+		(a, b) => a.position.start.col - b.position.start.col,
+	);
 	const lines = content.split("\n");
 
 	if (section) {

src/graph/builders/explicit/typed_link.ts

@@ -157,14 +157,18 @@ export const _add_explicit_edges_typed_link: ExplicitEdgeBuilder = async (
 		(all_files.obsidian ?? []).map(
 			async ({ file, cache }) => {
 				if (file.extension !== "md") return;
-				if (!cache?.links?.length) return;
+
+				// `[[wikilink]]` and `![[embed]]` land in separate cache arrays, but
+				// a Dataview field can hold either (e.g. `down:: ![[note]]`).
+				const links = [...(cache?.links ?? []), ...(cache?.embeds ?? [])];
+				if (!links.length) return;
 
 				const content = await plugin.app.vault.cachedRead(file);
 				const lines = content.split("\n");
 
 				const fields_by_line = new Map<number, InlineField[]>();
 
-				for (const link_cache of cache.links) {
+				for (const link_cache of links) {
 					const line_num = link_cache.position.start.line;
 
 					let fields = fields_by_line.get(line_num);

tests/graph/builders/helpers.ts

@@ -24,6 +24,8 @@ export function mock_file(
 		listItems?: { line: number; col: number; parent: number }[];
 		/** Body wikilinks keyed by line (list_note, typed_link builders) */
 		links?: { line: number; link: string; col?: number }[];
+		/** Body embeds keyed by line — `![[note]]` (typed_link builder) */
+		embeds?: { line: number; link: string; col?: number }[];
 		/** Headings (list_note section scoping): one per line */
 		headings?: { line: number; level: number; heading: string }[];
 	} = {},
@@ -49,6 +51,7 @@ export function mock_file(
 		opts.frontmatterLinks ||
 		opts.listItems ||
 		opts.links ||
+		opts.embeds ||
 		opts.headings;
 
 	const cache = has_cache
@@ -73,6 +76,13 @@ export function mock_file(
 						end: { line: l.line, col: l.col ?? 0, offset: 0 },
 					},
 				})),
+				embeds: opts.embeds?.map((l) => ({
+					link: l.link,
+					position: {
+						start: { line: l.line, col: l.col ?? 0, offset: 0 },
+						end: { line: l.line, col: l.col ?? 0, offset: 0 },
+					},
+				})),
 				headings: opts.headings?.map((h) => ({
 					heading: h.heading,
 					level: h.level,

tests/graph/builders/list_note.test.ts

@@ -45,6 +45,35 @@ describe("list_note builder", () => {
 		t.expect(r.edges[0]!.edge_source).toBe("list_note");
 	});
 
+	// #760: `![[Note]]` (an embed) lands in cache.embeds, not cache.links — a
+	// list item's outlink must still be picked up.
+	test("embedded wikilink list item becomes a child edge", async (t) => {
+		const content = "- ![[A]]\n- [[B]]";
+		const list = mock_file("list.md", {
+			frontmatter: { "BC-list-note-field": "down" },
+			listItems: [
+				{ line: 0, col: 0, parent: -1 },
+				{ line: 1, col: 0, parent: -1 },
+			],
+			embeds: [{ line: 0, link: "A", col: 2 }],
+			links: [{ line: 1, link: "B" }],
+		});
+
+		const r = await _add_explicit_edges_list_note(
+			make_plugin(
+				{ edge_fields: EDGE_FIELDS, explicit_edge_sources: {} as never },
+				[],
+				link_resolver(["A", "B"]),
+				{ cachedRead: async () => content },
+			),
+			make_all_files([list]),
+		);
+
+		const pairs = r.edges.map((e) => [e.source, e.target]);
+		t.expect(pairs).toContainEqual(["list.md", "A.md"]);
+		t.expect(pairs).toContainEqual(["list.md", "B.md"]);
+	});
+
 	test("note without BC-list-note-field is skipped", async (t) => {
 		const r = await _add_explicit_edges_list_note(
 			make_plugin(

tests/graph/builders/typed_link.test.ts

@@ -228,6 +228,38 @@ describe("typed_link builder — body inline fields", () => {
 		t.expect(r.edges[0]!.edge_type).toBe("up");
 		t.expect(r.edges[0]!.target).toBe("Note.md");
 	});
+
+	// #760: `![[note]]` (an embed) lands in cache.embeds, not cache.links —
+	// it must still be picked up as a field value.
+	test("embedded wikilink value → edge", async (t) => {
+		const body = "down:: ![[Convolutions]]";
+		const plugin = inline_plugin(body);
+		const all_files = make_all_files([
+			mock_file("a.md", {
+				embeds: [{ line: 0, link: "Convolutions", col: body.indexOf("!") }],
+			}),
+		]);
+		const r = await _add_explicit_edges_typed_link(plugin, all_files);
+
+		t.expect(r.edges).toHaveLength(1);
+		t.expect(r.edges[0]!.edge_type).toBe("down");
+		t.expect(r.edges[0]!.target).toBe("Convolutions.md");
+	});
+
+	test("wrapped field with embedded wikilink → edge", async (t) => {
+		const body = "(down:: ![[Convolutions]])";
+		const plugin = inline_plugin(body);
+		const all_files = make_all_files([
+			mock_file("a.md", {
+				embeds: [{ line: 0, link: "Convolutions", col: body.indexOf("!") }],
+			}),
+		]);
+		const r = await _add_explicit_edges_typed_link(plugin, all_files);
+
+		t.expect(r.edges).toHaveLength(1);
+		t.expect(r.edges[0]!.edge_type).toBe("down");
+		t.expect(r.edges[0]!.target).toBe("Convolutions.md");
+	});
 });
 
 describe("parse_inline_fields", () => {