bigfix(686) opening the Breadcrumbs settings tab

Author: michaelpporter

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. See [standa
 
 ## 4.X
 
+### [4.9.2](https://github.com/SkepticMystic/breadcrumbs/compare/4.9.1...4.9.2) (2026-05-12)
+
+### Bug Fixes
+
+* Fix [#686](https://github.com/SkepticMystic/breadcrumbs/issues/686) — opening the Breadcrumbs settings tab on some Android/Windows installs could freeze Obsidian's settings modal. The settings tab now wraps its render in a try/catch, logs the underlying error to the developer console, and shows a recoverable fallback UI with a "Reload settings" button instead of bricking the modal. Also serialised Svelte component teardown so `containerEl.empty()` no longer races pending `unmount()` promises, and `reactive_settings.current` falls back to defaults (with a warning) if read before init.
+
 ### [4.9.1](https://github.com/SkepticMystic/breadcrumbs/compare/4.9.0...4.9.1) (2026-05-11)
 
 ### Bug Fixes

manifest-beta.json

@@ -1,7 +1,7 @@
 {
 	"id": "breadcrumbs",
 	"name": "Breadcrumbs",
-	"version": "4.9.1",
+	"version": "4.9.2",
 	"minAppVersion": "1.12.0",
 	"description": "Add structured hierarchies to your notes",
 	"author": "SkepticMystic",

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "breadcrumbs",
 	"name": "Breadcrumbs",
-	"version": "4.9.1",
+	"version": "4.9.2",
 	"minAppVersion": "1.12.0",
 	"description": "Add structured hierarchies to your notes",
 	"author": "SkepticMystic",

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "breadcrumbs",
-	"version": "4.9.1",
+	"version": "4.9.2",
 	"description": "Add typed-links to your Obsidian notes",
 	"main": "main.js",
 	"scripts": {

src/settings/SettingsTab.ts

@@ -1,5 +1,6 @@
 import type { App } from "obsidian";
-import { PluginSettingTab } from "obsidian";
+import { Notice, PluginSettingTab } from "obsidian";
+import { log } from "src/logger";
 import type BreadcrumbsPlugin from "src/main";
 import { mount, unmount } from "svelte";
 import EdgeFieldSettings from "../components/settings/EdgeFieldSettings.svelte";
@@ -60,13 +61,50 @@ export class BreadcrumbsSettingTab extends PluginSettingTab {
 	display(): void {
 		const { containerEl, plugin } = this;
 
-		for (const c of this.components) void unmount(c);
+		const old_components = this.components;
 		this.components = [];
 
-		containerEl.empty();
+		void Promise.all(old_components.map((c) => unmount(c))).catch(
+			(error) => {
+				log.error("BreadcrumbsSettingTab.unmount threw >", error);
+			},
+		);
 
+		containerEl.empty();
 		containerEl.addClass("BC-settings-tab");
 
+		try {
+			this._build(containerEl, plugin);
+		} catch (error) {
+			log.error("BreadcrumbsSettingTab.display threw >", error);
+			new Notice(
+				"Breadcrumbs: failed to render settings tab. See developer console and report at https://github.com/SkepticMystic/breadcrumbs/issues",
+			);
+
+			containerEl.empty();
+			containerEl.addClass("BC-settings-tab");
+
+			const fallback = containerEl.createDiv({ cls: "p-4" });
+			fallback.createEl("h3", {
+				text: "Breadcrumbs settings failed to load",
+			});
+			fallback.createEl("p", {
+				text: String(
+					(error as Error)?.stack ??
+						(error as Error)?.message ??
+						error,
+				),
+				cls: "text-muted",
+			});
+
+			const retry = fallback.createEl("button", {
+				text: "Reload settings",
+			});
+			retry.onclick = () => this.display();
+		}
+	}
+
+	private _build(containerEl: HTMLElement, plugin: BreadcrumbsPlugin): void {
 		this.components.push(
 			mount(EdgeFieldSettings, {
 				props: { plugin },
@@ -215,7 +253,13 @@ export class BreadcrumbsSettingTab extends PluginSettingTab {
 	hide() {
 		void this.plugin.flushPendingSettings();
 
-		for (const c of this.components) void unmount(c);
+		const old_components = this.components;
 		this.components = [];
+
+		void Promise.all(old_components.map((c) => unmount(c))).catch(
+			(error) => {
+				log.error("BreadcrumbsSettingTab.unmount threw >", error);
+			},
+		);
 	}
 }

src/stores/reactive_settings.svelte.ts

@@ -1,11 +1,16 @@
+import { DEFAULT_SETTINGS } from "src/const/settings";
 import type { BreadcrumbsSettings } from "src/interfaces/settings";
+import { log } from "src/logger";
 
 let _settings = $state<BreadcrumbsSettings | null>(null);
 
 export const reactive_settings = {
 	get current(): BreadcrumbsSettings {
 		if (!_settings) {
-			throw new Error("reactive_settings accessed before init");
+			log.warn(
+				"reactive_settings accessed before init — returning defaults",
+			);
+			_settings = structuredClone(DEFAULT_SETTINGS);
 		}
 		return _settings;
 	},

versions.json

@@ -270,5 +270,6 @@
 	"4.9.0-beta.0": "1.12.0",
 	"4.9.0-beta.1": "1.12.0",
 	"4.9.0": "1.12.0",
-	"4.9.1": "1.12.0"
+	"4.9.1": "1.12.0",
+	"4.9.2": "1.12.0"
 }