Search results for config file might be unintuitive

[naitian]

This is a bug in code that I wrote (oops).

I'm pretty sure if your directory structure looks like this:

- dir/
  - sink.config.json
  - dir2/
    - config.json

and you run sink inside of dir2, it will use sink.config.json instead of config.json.

This is because the config search runs findUp for each potentially config filename, instead of searching for all of the config files at each level of the directory. Pretty sure this can be fixed by just passing in the array of filenames.

[erxclau]

Can take a look at this sometime this week. Is that directory structure something you use? Generally curious about how you've been using sink.

[erxclau]

Update here: passing an array of filenames didn't work as expected. findUp tries to find the files relative to a directory. By default, it tries to find relative to the current working directory through Node's process.cwd(). However, even when running sink in a subdirectory, it seems that Node considers the root of the project to be the current working directory. And I'm not too sure if there's a built in Node function to find the correct subdirectory that the user executes sink from...

This could be a matter really of how yarn works.