fix (plg_backend_psql): caching issue

Author: mickael-kerjean

server/plugin/plg_backend_psql/index.go

@@ -11,32 +11,16 @@ import (
 	_ "github.com/lib/pq"
 )
 
-var PGCache AppCache
-
 type PSQL struct {
 	db  *sql.DB
 	ctx context.Context
 }
 
 func init() {
 	Backend.Register("psql", PSQL{})
-
-	PGCache = NewAppCache(2, 1)
-	PGCache.OnEvict(func(key string, value interface{}) {
-		c := value.(*PSQL)
-		c.Close()
-	})
 }
 
 func (this PSQL) Init(params map[string]string, app *App) (IBackend, error) {
-	if d := PGCache.Get(params); d != nil {
-		backend := d.(*PSQL)
-		if backend.db.Ping() == nil {
-			backend.ctx = app.Context
-			return backend, nil
-		}
-		PGCache.Del(params)
-	}
 	host := params["host"]
 	port := withDefault(params["port"], "5432")
 	user := params["user"]
@@ -64,7 +48,6 @@ func (this PSQL) Init(params map[string]string, app *App) (IBackend, error) {
 		db:  db,
 		ctx: app.Context,
 	}
-	PGCache.Set(params, backend)
 	return backend, nil
 }
 
@@ -118,21 +101,25 @@ func (this PSQL) LoginForm() Form {
 }
 
 func (this PSQL) Touch(path string) error {
+	defer this.Close()
 	if !strings.HasSuffix(path, ".form") {
 		return ErrNotValid
 	}
 	return nil
 }
 
 func (this PSQL) Rm(path string) error {
+	defer this.Close()
 	return ErrNotAuthorized
 }
 
 func (this PSQL) Mkdir(path string) error {
+	defer this.Close()
 	return ErrNotValid
 }
 
 func (this PSQL) Mv(from string, to string) error {
+	defer this.Close()
 	return ErrNotValid
 }
 

server/plugin/plg_backend_psql/index_cat.go

@@ -11,6 +11,7 @@ import (
 )
 
 func (this PSQL) Cat(path string) (io.ReadCloser, error) {
+	defer this.Close()
 	l, err := getPath(path)
 	if err != nil {
 		return nil, err

server/plugin/plg_backend_psql/index_ls.go

@@ -7,6 +7,7 @@ import (
 )
 
 func (this PSQL) Ls(path string) ([]os.FileInfo, error) {
+	defer this.Close()
 	l, err := getPath(path)
 	if err != nil {
 		Log.Debug("pl_backend_psql::ls method=getPath err=%s", err.Error())

server/plugin/plg_backend_psql/index_save.go

@@ -13,6 +13,7 @@ import (
 )
 
 func (this PSQL) Save(path string, file io.Reader) error {
+	defer this.Close()
 	l, err := getPath(path)
 	if err != nil {
 		return err