Commit d86b777
committed
Fix crash in getCurrentPixelSizeConfig
Fix a regression in #891.
When `cached` is true and one of the properties is not in the cache, we
were dereferencing an empty std::optional.
Also elide the throw-catch for handling properties not in the cache.
Exceptions are not good for control flow in C++.
(Assisted by Claude Code; any errors are mine.)1 parent 8399a00 commit d86b777
1 file changed
Lines changed: 13 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5873 | 5873 | | |
5874 | 5874 | | |
5875 | 5875 | | |
5876 | | - | |
| 5876 | + | |
| 5877 | + | |
5877 | 5878 | | |
5878 | | - | |
5879 | | - | |
| 5879 | + | |
5880 | 5880 | | |
5881 | 5881 | | |
5882 | 5882 | | |
5883 | | - | |
| 5883 | + | |
5884 | 5884 | | |
5885 | | - | |
| 5885 | + | |
| 5886 | + | |
5886 | 5887 | | |
5887 | | - | |
5888 | | - | |
5889 | 5888 | | |
5890 | | - | |
| 5889 | + | |
5891 | 5890 | | |
5892 | | - | |
5893 | | - | |
| 5891 | + | |
| 5892 | + | |
| 5893 | + | |
| 5894 | + | |
5894 | 5895 | | |
| 5896 | + | |
| 5897 | + | |
5895 | 5898 | | |
5896 | 5899 | | |
5897 | 5900 | | |
| |||
0 commit comments