Upgrade Storybook 8 to 10 - #9
Merged
Merged
Conversation
Applied the same changes as makecode-embed's upgrade, verified with the full ci script. Drop unused addons: essentials and interactions are core in Storybook 9+; links, docs and Chromatic were unused (no linkTo, MDX, autodocs tags, or Chromatic CI). This leaves storybook, @storybook/react-vite and eslint-plugin-storybook as the only Storybook dev dependencies. The docs.autodocs option was removed in Storybook 9. Story and preview imports move from @storybook/react to @storybook/react-vite as direct renderer imports are deprecated. Ignore generated docs/build in eslint: a new eslint-plugin-storybook rule flags stale typedoc output there. Disable the onboarding checklist and what's new notifications. The lockfile is regenerated as npm could not resolve the major bumps in place.
Contributor
Author
|
Motivated by npm/renovate tying itself in knots (and wasting 15 mins of timeout) on this upgrade. |
Deploying python-editor-embed with
|
| Latest commit: |
b2cbdab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://878ef8f6.python-editor-embed.pages.dev |
| Branch Preview URL: | https://storybook-10.python-editor-embed.pages.dev |
| @@ -1,4 +1,4 @@ | |||
| import type { Preview } from "@storybook/react"; | |||
| import type { Preview } from "@storybook/react-vite"; | |||
Contributor
Author
There was a problem hiding this comment.
This seemed weird but is an intentional restructuring that should address exactly the issue that meant it was hard to just npm upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied the same changes as makecode-embed's upgrade, verified with the full ci script.
Drop unused addons: essentials and interactions are core in Storybook 9+; links, docs and Chromatic were unused (no linkTo, MDX, autodocs tags, or Chromatic CI). This leaves storybook, @storybook/react-vite and eslint-plugin-storybook as the only Storybook dev dependencies. The docs.autodocs option was removed in Storybook 9.
Story and preview imports move from @storybook/react to @storybook/react-vite as direct renderer imports are deprecated.
Ignore generated docs/build in eslint: a new eslint-plugin-storybook rule flags stale typedoc output there.
Disable the onboarding checklist and what's new notifications.
The lockfile is regenerated as npm could not resolve the major bumps in place.