Commit 30aaec8
committed
Use the shared MoreMenuButton and ButtonGroup seam
@microbit/ui's ButtonGroup now draws the seam between attached buttons
itself: a 1px hairline in the variant's border colour, or a gap where the
variant has no border to lend. That is what the split buttons here
already hand-wrote — a `borderRight` and a `borderLeft` either side of
the group's -1px overlap — so the save and send buttons lose their local
borders, and MoreMenuButton goes up to the shared package with them.
The zoom and undo/redo pills drop their gray.10 dividers for the same
reason. `neutral` has no border, so their seam is now a gap showing the
page through rather than a near-white line drawn over the grey; on this
surface that is the same pixels.
No visual change intended.
See microbit-foundation/ui#221 parent ea0f420 commit 30aaec8
5 files changed
Lines changed: 9 additions & 55 deletions
File tree
- src
- editor
- project
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
7 | 13 | | |
8 | 14 | | |
9 | 15 | | |
10 | 16 | | |
11 | | - | |
12 | 17 | | |
13 | 18 | | |
14 | 19 | | |
| |||
29 | 34 | | |
30 | 35 | | |
31 | 36 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | | - | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments