Skip to content

Commit 4bdce37

Browse files
Restore 16px 'Don't show this again' dialog links
These were Chakra <Link as="button">: no size scale, so they inherited the dialog's 16px document size. The port to Button variant="link" brought the Button size scale with it (md = 14.4px on this app's shrunken fontSizes), silently shrinking them. size="lg" (16.2px) is the nearest scale size; the link variant still zeroes lg's height/padding. Verified against production: box centres within 0.25px. ModuleOverlay's inline link is the other Link-conversion but sits in md Text where inherited and variant sizes coincide — unchanged.
1 parent 874a321 commit 4bdce37

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

src/common/GenericDialog.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ export const GenericDialogFooter = ({
7676
{!dialogNormallyHidden && !shownByRequest && (
7777
<Button
7878
variant="link"
79+
size="lg"
7980
onPress={onCloseDontShowAgain}
8081
css={{ color: "brand.500", mr: "auto" }}
8182
>

src/workbench/connect-dialogs/ConnectDialog.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ const ConnectDialogFooter = ({
100100
{!dialogNormallyHidden && !shownByRequest && (
101101
<Button
102102
variant="link"
103+
size="lg"
103104
onPress={onNextDontShowAgain}
104105
css={{ color: "brand.500", mr: "auto" }}
105106
>

0 commit comments

Comments
 (0)