Skip to content

Commit 586df42

Browse files
Drop the no-op isRound prop from icon buttons
It is being removed from @microbit/ui: the 2rem button radius already clamps to a full round at every size, so the prop changed nothing here. No visual change. See microbit-foundation/ui#4
1 parent 23cdd00 commit 586df42

6 files changed

Lines changed: 0 additions & 8 deletions

File tree

src/editor/UndoRedoControls.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ const UndoRedoControls = ({ css: cssProp }: UndoRedoControlsProps) => {
3131
}}
3232
>
3333
<IconButton
34-
isRound
3534
variant="neutral"
3635
aria-label={intl.formatMessage({ id: "undo" })}
3736
onPress={actions?.undo}
@@ -40,7 +39,6 @@ const UndoRedoControls = ({ css: cssProp }: UndoRedoControlsProps) => {
4039
<RiArrowGoBackLine style={{ transform: "rotate(-90deg)" }} />
4140
</IconButton>
4241
<IconButton
43-
isRound
4442
variant="neutral"
4543
css={{ borderLeft: "1px solid", borderLeftColor: "gray.10" }}
4644
aria-label={intl.formatMessage({ id: "redo" })}

src/editor/ZoomControls.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ const ZoomControls = ({ size, css: cssProp }: ZoomControlsProps) => {
4646
<ButtonGroup css={cssProp} isAttached>
4747
<IconButton
4848
size={size}
49-
isRound
5049
variant="neutral"
5150
aria-label={intl.formatMessage({ id: "zoom-out-action" })}
5251
onPress={handleZoomOut}
@@ -56,7 +55,6 @@ const ZoomControls = ({ size, css: cssProp }: ZoomControlsProps) => {
5655
<IconButton
5756
css={{ borderLeft: "1px solid", borderLeftColor: "gray.10" }}
5857
size={size}
59-
isRound
6058
variant="neutral"
6159
aria-label={intl.formatMessage({ id: "zoom-in-action" })}
6260
onPress={handleZoomIn}

src/serial/SerialBar.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ const SerialBar = ({
120120
{showHintsAndTips && (
121121
<IconButton
122122
variant="sidebar"
123-
isRound
124123
aria-label={intl.formatMessage({ id: "serial-hints-and-tips" })}
125124
onPress={handleShowHintsAndTips}
126125
>

src/serial/SerialMenu.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ const SerialMenu = React.forwardRef(
3838
ref={menuButtonRef}
3939
aria-label={intl.formatMessage({ id: "serial-menu" })}
4040
variant="sidebar"
41-
isRound
4241
>
4342
<MdMoreVert />
4443
</IconButton>

src/settings/SettingsMenu.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ const SettingsMenu = ({ size }: SettingsMenuProps) => {
4949
size={size}
5050
css={{ fontSize: "xl" }}
5151
variant="sidebar"
52-
isRound
5352
>
5453
<RiSettings2Line />
5554
</IconButton>

src/workbench/HelpMenu.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ const HelpMenu = ({ size }: HelpMenuProps) => {
6464
size={size}
6565
css={{ fontSize: "xl" }}
6666
variant="sidebar"
67-
isRound
6867
>
6968
<RiQuestionLine />
7069
</IconButton>

0 commit comments

Comments
 (0)