feat!: rewrite the postinstall script (#192)

* fix: post-install should fail on error

* chore: dump simple-get

* chore: bump node version requirement

* chore: npm,yarn,pnpm already implicitly hide logs

* chore: follow convention

* refactor: use debug-logfmt

* refactor: remove simple-get dependency

* refactor: remove unnecessary line

* refactor: remove unnecessary lines

* docs: add DEBUG

* refactor: drop unnecessary line

* fix: log report

---------

Co-authored-by: Kiko Beats <[email protected]>

Author: miraclx

README.md

@@ -144,6 +144,10 @@ These environment variables can also be set through "npm config", for example `n
 
 They setup the download configuration for getting the `yt-dlp` binary file.
 
+### DEBUG
+
+Set `DEBUG="youtube-dl-exec*"` to enable debug mode. This will enable log additional information during the post-install script.
+
 ### YOUTUBE_DL_DIR
 
 It determines the folder where to put the binary file.

package.json

@@ -117,8 +117,8 @@
   "dependencies": {
     "bin-version-check": "~6.0.0",
     "dargs": "~7.0.0",
+    "debug-logfmt": "~1.2.2",
     "is-unix": "~2.0.10",
-    "simple-get": "~4.0.1",
     "tinyspawn": "~1.2.6"
   },
   "devDependencies": {
@@ -139,7 +139,7 @@
     "tsd": "latest"
   },
   "engines": {
-    "node": ">= 14"
+    "node": ">= 18"
   },
   "files": [
     "scripts",

scripts/postinstall.js

@@ -1,22 +1,9 @@
 'use strict'
 
-const { writeFile, mkdir } = require('fs/promises')
-const { concat } = require('simple-get')
-
-const mkdirp = filepath => mkdir(filepath, { recursive: true }).catch(() => {})
-
-const get = url =>
-  new Promise((resolve, reject) =>
-    concat(
-      {
-        url,
-        headers: {
-          'user-agent': 'microlinkhq/youtube-dl-exec'
-        }
-      },
-      (err, response, data) => (err ? reject(err) : resolve({ response, data }))
-    )
-  )
+const debug = require('debug-logfmt')('youtube-dl-exec:install')
+const { mkdir, chmod } = require('node:fs/promises')
+const { pipeline } = require('node:stream/promises')
+const { createWriteStream } = require('node:fs')
 
 const {
   YOUTUBE_DL_PATH,
@@ -26,23 +13,31 @@ const {
   YOUTUBE_DL_SKIP_DOWNLOAD
 } = require('../src/constants')
 
-const getLatest = data => {
-  const { assets } = JSON.parse(data)
+const getLatest = ({ assets }) => {
   const { browser_download_url: url } = assets.find(
     ({ name }) => name === YOUTUBE_DL_FILE
   )
-  return get(url).then(({ data }) => data)
+  return fetch(url)
 }
 
 const getBinary = async url => {
-  const { response, data } = await get(url)
-  return response.headers['content-type'] === 'application/octet-stream'
-    ? data
-    : getLatest(data)
+  let response = await fetch(url)
+  if (response.headers.get('content-type') !== 'application/octet-stream') {
+    response = await getLatest(await response.json())
+  }
+  return response.body
 }
 
-if (!YOUTUBE_DL_SKIP_DOWNLOAD) {
-  Promise.all([getBinary(YOUTUBE_DL_HOST), mkdirp(YOUTUBE_DL_DIR)])
-    .then(([buffer]) => writeFile(YOUTUBE_DL_PATH, buffer, { mode: 0o755 }))
-    .catch(err => console.error(err.message || err))
+const installBinary = async () => {
+  debug('downloading', { url: YOUTUBE_DL_HOST })
+  const [binary] = await Promise.all([
+    getBinary(YOUTUBE_DL_HOST),
+    mkdir(YOUTUBE_DL_DIR, { recursive: true })
+  ])
+  debug('writing', { path: YOUTUBE_DL_PATH })
+  await pipeline(binary, createWriteStream(YOUTUBE_DL_PATH))
+  await chmod(YOUTUBE_DL_PATH, 0o755)
+  debug({ status: 'success' })
 }
+
+YOUTUBE_DL_SKIP_DOWNLOAD ? debug({ status: 'skipped' }) : installBinary()