Skip to content

Remove regex pattern from ParsingUtils (resolve TODO) #365

@fynnjuranek

Description

@fynnjuranek

Hey,

I've noticed a TODO in the ParsingUtils class mentioning that the current approach for retrieving the class name of KeyNames when using the merge method could use some improvement.

I believe I've found a solution and created a PR with the changes.

Solution (PR: #366)

The solution involves replacing the regex pattern usage with AST parsing, similar to how we retrieve expressions, and I think the overall consistency of the class has improved. The existing functionality remains unchanged, and all tests have passed, including those in my example project. Additionally, I've added a new test case to ensure everything works with nested KeyNames.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions