Skip to content

Allow customization of netty http client mapper #647

@yawkat

Description

@yawkat

Issue description

Right now it is impossible to customize the serializer used by the netty http client. It is a static field in OciSdkMicronautSerializer without any config options.

There's this TODO:

Additionally, NettyHttpResponse needs to be adjusted to use the proper mapper.

One option would be to use the JsonMapper from the context. It is already injected in ManagedNettyHttpProvider. This would also restore compatibility with jackson-databind (needs testing though). One potential issue is that global configuration of the mapper would impact the oci sdk, which might not be intended. As of serde 2.0 (time serialization changes), it should work fine with defaults, however.

An alternative would be to use a separate mapper, but allow configuration in the context.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: improvementA minor improvement to an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions