Skip to content

Commit a3842af

Browse files
authored
Merge pull request #655 from Ladicek/fix-cb-telemetry-test
baseline metrics in CircuitBreakerTelemetryTest
2 parents b3ea467 + a07cd05 commit a3842af

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Diff for: tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/metrics/CircuitBreakerMetricTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
import org.jboss.shrinkwrap.api.asset.EmptyAsset;
4545
import org.jboss.shrinkwrap.api.spec.JavaArchive;
4646
import org.jboss.shrinkwrap.api.spec.WebArchive;
47-
import org.testng.annotations.BeforeTest;
47+
import org.testng.annotations.BeforeMethod;
4848
import org.testng.annotations.Test;
4949

5050
import jakarta.inject.Inject;
@@ -75,7 +75,7 @@ public static WebArchive deploy() {
7575
@Inject
7676
private CircuitBreakerMetricBean cbBean;
7777

78-
@BeforeTest
78+
@BeforeMethod
7979
public void closeTheCircuit() throws Exception {
8080

8181
// Condition is needed because BeforeTest runs on both client and server

Diff for: tck/src/main/java/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/CircuitBreakerTelemetryTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
import org.jboss.shrinkwrap.api.asset.StringAsset;
5454
import org.jboss.shrinkwrap.api.spec.JavaArchive;
5555
import org.jboss.shrinkwrap.api.spec.WebArchive;
56-
import org.testng.annotations.BeforeTest;
56+
import org.testng.annotations.BeforeMethod;
5757
import org.testng.annotations.Test;
5858

5959
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
@@ -90,7 +90,7 @@ public static WebArchive deploy() {
9090
@Inject
9191
private CircuitBreakerMetricBean cbBean;
9292

93-
@BeforeTest
93+
@BeforeMethod
9494
public void closeTheCircuit() throws Exception {
9595

9696
// Condition is needed because BeforeTest runs on both client and server
@@ -120,6 +120,7 @@ public void closeTheCircuit() throws Exception {
120120
@Test
121121
public void testCircuitBreakerMetric() throws Exception {
122122
TelemetryMetricGetter m = new TelemetryMetricGetter(CircuitBreakerMetricBean.class, "doWork");
123+
m.baselineMetrics();
123124

124125
// First failure, circuit remains closed
125126
expectTestException(() -> cbBean.doWork(Result.FAIL));

0 commit comments

Comments
 (0)