GP Updates - July 2024 (#26821)

This update enhances the GP migrations by:

- Migrating GP Kit Items as BC Assembly BOMs.
- Prevent migration error when Customer/Vendor phone numbers contain
alpha characters. The Customer/Vendors will be migrated, but the
phone/fax numbers with alpha characters will be ignored and added to the
Warning Log.
- History Gen. Journal Line - View Distributions feature.
- Updated labels in settings area to specify 'migration' instead of
'upgrade' to prevent customer confusion.

Fixes #26487
Fixes
[AB#543399](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/543399)

---------

Co-authored-by: jaymckinney <[email protected]>

Author: jaymckinney-enavate

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistGenJournalLines.Page.al

@@ -144,14 +144,23 @@ page 41001 "Hist. Gen. Journal Lines"
     trigger OnOpenPage()
     begin
         if FilterAccountNo <> '' then
-            Rec.SetFilter("Account No.", FilterAccountNo);
+            Rec.SetRange("Account No.", FilterAccountNo);
+
+        if FilterOriginatingTrxSourceNo <> '' then
+            Rec.SetRange("Orig. Trx. Source No.", FilterOriginatingTrxSourceNo);
     end;
 
     procedure SetFilterAccountNo(AccountNo: Code[130])
     begin
         FilterAccountNo := AccountNo;
     end;
 
+    procedure SetFilterOriginatingTrxSourceNo(OriginatingTrxSourceNo: Code[35])
+    begin
+        FilterOriginatingTrxSourceNo := OriginatingTrxSourceNo;
+    end;
+
     var
         FilterAccountNo: Code[130];
+        FilterOriginatingTrxSourceNo: Code[35];
 }

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistInventoryTrx.Page.al

@@ -81,6 +81,34 @@ page 41010 "Hist. Inventory Trx."
         }
     }
 
+    actions
+    {
+        area(Promoted)
+        {
+            actionref(ViewDistributions_Promoted; ViewDistributions)
+            {
+            }
+        }
+        area(Processing)
+        {
+            action(ViewDistributions)
+            {
+                ApplicationArea = All;
+                Caption = 'View Distributions';
+                ToolTip = 'View the G/L account distributions related to this transaction.';
+                Image = RelatedInformation;
+
+                trigger OnAction()
+                var
+                    HistGenJournalLines: Page "Hist. Gen. Journal Lines";
+                begin
+                    HistGenJournalLines.SetFilterOriginatingTrxSourceNo(Rec."Audit Code");
+                    HistGenJournalLines.Run();
+                end;
+            }
+        }
+    }
+
     trigger OnAfterGetCurrRecord()
     begin
         DataCaptionExpressionTxt := Format(Rec."Document Type") + ' - ' + Rec."Document No.";

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistPayablesDocument.Page.al

@@ -195,6 +195,34 @@ page 41008 "Hist. Payables Document"
         }
     }
 
+    actions
+    {
+        area(Promoted)
+        {
+            actionref(ViewDistributions_Promoted; ViewDistributions)
+            {
+            }
+        }
+        area(Processing)
+        {
+            action(ViewDistributions)
+            {
+                ApplicationArea = All;
+                Caption = 'View Distributions';
+                ToolTip = 'View the G/L account distributions related to this transaction.';
+                Image = RelatedInformation;
+
+                trigger OnAction()
+                var
+                    HistGenJournalLines: Page "Hist. Gen. Journal Lines";
+                begin
+                    HistGenJournalLines.SetFilterOriginatingTrxSourceNo(Rec."Audit Code");
+                    HistGenJournalLines.Run();
+                end;
+            }
+        }
+    }
+
     trigger OnAfterGetCurrRecord()
     begin
         CurrPage.HistPayablesApplyList.Page.FilterByVoucherNo(Rec."Document Type", Rec."Voucher No.");

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistPurchaseRecv.Page.al

@@ -181,6 +181,34 @@ page 41013 "Hist. Purchase Recv."
         }
     }
 
+    actions
+    {
+        area(Promoted)
+        {
+            actionref(ViewDistributions_Promoted; ViewDistributions)
+            {
+            }
+        }
+        area(Processing)
+        {
+            action(ViewDistributions)
+            {
+                ApplicationArea = All;
+                Caption = 'View Distributions';
+                ToolTip = 'View the G/L account distributions related to this transaction.';
+                Image = RelatedInformation;
+
+                trigger OnAction()
+                var
+                    HistGenJournalLines: Page "Hist. Gen. Journal Lines";
+                begin
+                    HistGenJournalLines.SetFilterOriginatingTrxSourceNo(Rec."Audit Code");
+                    HistGenJournalLines.Run();
+                end;
+            }
+        }
+    }
+
     trigger OnAfterGetCurrRecord()
     begin
         DataCaptionExpressionTxt := Format(Rec."Document Type") + ' - ' + Rec."Receipt No.";

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistReceivablesDocument.Page.al

@@ -185,6 +185,34 @@ page 41006 "Hist. Receivables Document"
         }
     }
 
+    actions
+    {
+        area(Promoted)
+        {
+            actionref(ViewDistributions_Promoted; ViewDistributions)
+            {
+            }
+        }
+        area(Processing)
+        {
+            action(ViewDistributions)
+            {
+                ApplicationArea = All;
+                Caption = 'View Distributions';
+                ToolTip = 'View the G/L account distributions related to this transaction.';
+                Image = RelatedInformation;
+
+                trigger OnAction()
+                var
+                    HistGenJournalLines: Page "Hist. Gen. Journal Lines";
+                begin
+                    HistGenJournalLines.SetFilterOriginatingTrxSourceNo(Rec."Audit Code");
+                    HistGenJournalLines.Run();
+                end;
+            }
+        }
+    }
+
     trigger OnAfterGetCurrRecord()
     begin
         CurrPage.HistReceivablesApplyList.Page.FilterByDocumentNo(Rec."Document Type", Rec."Document No.");

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistSalesTrx.Page.al

@@ -195,6 +195,34 @@ page 41007 "Hist. Sales Trx."
         }
     }
 
+    actions
+    {
+        area(Promoted)
+        {
+            actionref(ViewDistributions_Promoted; ViewDistributions)
+            {
+            }
+        }
+        area(Processing)
+        {
+            action(ViewDistributions)
+            {
+                ApplicationArea = All;
+                Caption = 'View Distributions';
+                ToolTip = 'View the G/L account distributions related to this transaction.';
+                Image = RelatedInformation;
+
+                trigger OnAction()
+                var
+                    HistGenJournalLines: Page "Hist. Gen. Journal Lines";
+                begin
+                    HistGenJournalLines.SetFilterOriginatingTrxSourceNo(Rec."Audit Code");
+                    HistGenJournalLines.Run();
+                end;
+            }
+        }
+    }
+
     trigger OnAfterGetCurrRecord()
     begin
         DataCaptionExpressionTxt := Rec."No.";

Apps/W1/DynamicsGPHistoricalData/app/src/Tables/HistGenJournalLine.Table.al

@@ -138,5 +138,8 @@ table 40901 "Hist. Gen. Journal Line"
         {
             IncludedFields = "Source Type", "Journal Entry No.", "Audit Code";
         }
+        key(Key3; "Orig. Trx. Source No.")
+        {
+        }
     }
 }

Apps/W1/HybridGP/app/Permissions/HybridGPEdit.PermissionSet.al

@@ -113,5 +113,6 @@ permissionset 4031 "HybridGP - Edit"
                     tabledata "GP PM30300" = IMD,
                     tabledata "GP RM20201" = IMD,
                     tabledata "GP RM30201" = IMD,
-                    tabledata "GP Migration Warnings" = IMD;
+                    tabledata "GP Migration Warnings" = IMD,
+                    tabledata "GP IV00104" = IMD;
 }

Apps/W1/HybridGP/app/Permissions/HybridGPObjects.PermissionSet.al

@@ -152,5 +152,6 @@ permissionset 4029 "HybridGP - Objects"
                     table "GP RM30201" = X,
                     table "GP Migration Warnings" = X,
                     page "GP Migration Warnings" = X,
-                    page "GP Payment Terms" = X;
+                    page "GP Payment Terms" = X,
+                    table "GP IV00104" = X;
 }

Apps/W1/HybridGP/app/Permissions/HybridGPRead.PermissionSet.al

@@ -113,5 +113,6 @@ permissionset 4032 "HybridGP - Read"
                     tabledata "GP PM30300" = R,
                     tabledata "GP RM20201" = R,
                     tabledata "GP RM30201" = R,
-                    tabledata "GP Migration Warnings" = R;
+                    tabledata "GP Migration Warnings" = R,
+                    tabledata "GP IV00104" = R;
 }

Apps/W1/HybridGP/app/Permissions/INTELLIGENTCLOUDHGP.PermissionSetExt.al

@@ -111,5 +111,6 @@ permissionsetextension 4028 "INTELLIGENT CLOUD - HGP" extends "INTELLIGENT CLOUD
                   tabledata "GP PM30300" = RIMD,
                   tabledata "GP RM20201" = RIMD,
                   tabledata "GP RM30201" = RIMD,
-                  tabledata "GP Migration Warnings" = RIMD;
+                  tabledata "GP Migration Warnings" = RIMD,
+                  tabledata "GP IV00104" = RIMD;
 }

Apps/W1/HybridGP/app/Permissions/d365basicHGP.permissionsetext.al

@@ -110,5 +110,6 @@ permissionsetextension 4025 "D365 BASIC - HGP" extends "D365 BASIC"
                   tabledata "GP PM30300" = RIMD,
                   tabledata "GP RM20201" = RIMD,
                   tabledata "GP RM30201" = RIMD,
-                  tabledata "GP Migration Warnings" = RIMD;
+                  tabledata "GP Migration Warnings" = RIMD,
+                  tabledata "GP IV00104" = RIMD;
 }

Apps/W1/HybridGP/app/Permissions/d365basicisvHGP.permissionsetext.al

@@ -109,5 +109,6 @@ permissionsetextension 4026 "D365 BASIC ISV - HGP" extends "D365 BASIC ISV"
                   tabledata "GP PM30300" = RIMD,
                   tabledata "GP RM20201" = RIMD,
                   tabledata "GP RM30201" = RIMD,
-                  tabledata "GP Migration Warnings" = RIMD;
+                  tabledata "GP Migration Warnings" = RIMD,
+                  tabledata "GP IV00104" = RIMD;
 }

Apps/W1/HybridGP/app/Permissions/d365teammemberHGP.permissionsetext.al

@@ -110,5 +110,6 @@ permissionsetextension 4027 "D365 TEAM MEMBER - HGP" extends "D365 TEAM MEMBER"
                   tabledata "GP PM30300" = RIMD,
                   tabledata "GP RM20201" = RIMD,
                   tabledata "GP RM30201" = RIMD,
-                  tabledata "GP Migration Warnings" = RIMD;
+                  tabledata "GP Migration Warnings" = RIMD,
+                  tabledata "GP IV00104" = RIMD;
 }

Apps/W1/HybridGP/app/src/Migration/Customers/GPCustomerMigrator.codeunit.al

@@ -15,7 +15,10 @@ codeunit 4018 "GP Customer Migrator"
         SourceCodeTxt: Label 'GENJNL', Locked = true;
         PostingGroupDescriptionTxt: Label 'Migrated from GP', Locked = true;
         CustomerEmailTypeCodeLbl: Label 'CUS', Locked = true;
+        MigrationLogAreaTxt: Label 'Customer', Locked = true;
+        PhoneNumberContainsLettersMsg: Label 'Phone/Fax number skipped because it contains letters. Value=%1', Comment = '%1 is the phone/fax number.';
 
+#pragma warning disable AA0207
     [EventSubscriber(ObjectType::Codeunit, Codeunit::"Customer Data Migration Facade", 'OnMigrateCustomer', '', true, true)]
     internal procedure OnMigrateCustomer(var Sender: Codeunit "Customer Data Migration Facade"; RecordIdToMigrate: RecordId)
     var
@@ -268,7 +271,6 @@ codeunit 4018 "GP Customer Migrator"
         GPSY01200: Record "GP SY01200";
         Customer: Record Customer;
         GPCompanyAdditionalSettings: Record "GP Company Additional Settings";
-        HelperFunctions: Codeunit "Helper Functions";
         DataMigrationErrorLogging: Codeunit "Data Migration Error Logging";
         PaymentTermsFormula: DateFormula;
         Country: Code[10];
@@ -306,10 +308,7 @@ codeunit 4018 "GP Customer Migrator"
             CopyStr(MigrationGPCustomer.CITY, 1, 30));
 
         CustomerDataMigrationFacade.SetContact(CopyStr(MigrationGPCustomer.CNTCPRSN, 1, 50));
-        MigrationGPCustomer.PHONE1 := HelperFunctions.CleanGPPhoneOrFaxNumber(MigrationGPCustomer.PHONE1);
-        MigrationGPCustomer.FAX := HelperFunctions.CleanGPPhoneOrFaxNumber(MigrationGPCustomer.FAX);
-        CustomerDataMigrationFacade.SetPhoneNo(MigrationGPCustomer.PHONE1);
-        CustomerDataMigrationFacade.SetFaxNo(MigrationGPCustomer.FAX);
+        SetPhoneAndFaxNumberIfValid(MigrationGPCustomer, CustomerDataMigrationFacade);
 
         if GPCompanyAdditionalSettings.GetGLModuleEnabled() then begin
             CustomerDataMigrationFacade.SetCustomerPostingGroup(CopyStr(PostingGroupCodeTxt, 1, 5));
@@ -360,6 +359,29 @@ codeunit 4018 "GP Customer Migrator"
         CustomerDataMigrationFacade.ModifyCustomer(true);
     end;
 
+    local procedure SetPhoneAndFaxNumberIfValid(var MigrationGPCustomer: Record "GP Customer"; var CustomerDataMigrationFacade: Codeunit "Customer Data Migration Facade")
+    var
+        GPMigrationWarnings: Record "GP Migration Warnings";
+        HelperFunctions: Codeunit "Helper Functions";
+        WarningContext: Text[50];
+    begin
+        WarningContext := CopyStr(MigrationGPCustomer.CUSTNMBR.Trim(), 1, MaxStrLen(GPMigrationWarnings.Context));
+        MigrationGPCustomer.PHONE1 := HelperFunctions.CleanGPPhoneOrFaxNumber(MigrationGPCustomer.PHONE1);
+        MigrationGPCustomer.FAX := HelperFunctions.CleanGPPhoneOrFaxNumber(MigrationGPCustomer.FAX);
+
+        if MigrationGPCustomer.PHONE1 <> '' then
+            if not HelperFunctions.ContainsAlphaChars(MigrationGPCustomer.PHONE1) then
+                CustomerDataMigrationFacade.SetPhoneNo(MigrationGPCustomer.PHONE1)
+            else
+                GPMigrationWarnings.InsertWarning(MigrationLogAreaTxt, WarningContext, StrSubstNo(PhoneNumberContainsLettersMsg, MigrationGPCustomer.PHONE1));
+
+        if MigrationGPCustomer.FAX <> '' then
+            if not HelperFunctions.ContainsAlphaChars(MigrationGPCustomer.FAX) then
+                CustomerDataMigrationFacade.SetFaxNo(MigrationGPCustomer.FAX)
+            else
+                GPMigrationWarnings.InsertWarning(MigrationLogAreaTxt, WarningContext, StrSubstNo(PhoneNumberContainsLettersMsg, MigrationGPCustomer.FAX));
+    end;
+
     local procedure MigrateCustomerAddresses(MigrationGPCustomer: Record "GP Customer")
     var
         GPCustomerAddress: Record "GP Customer Address";

Apps/W1/HybridGP/app/src/Migration/GPTables/GPIV00104.Table.al

@@ -0,0 +1,44 @@
+namespace Microsoft.DataMigration.GP;
+
+table 41007 "GP IV00104"
+{
+    DataClassification = CustomerContent;
+    fields
+    {
+        field(1; ITEMNMBR; Text[31])
+        {
+            DataClassification = CustomerContent;
+        }
+        field(2; SEQNUMBR; Integer)
+        {
+            DataClassification = CustomerContent;
+        }
+        field(3; CMPTITNM; Text[31])
+        {
+            DataClassification = CustomerContent;
+        }
+        field(4; CMPITUOM; Text[9])
+        {
+            DataClassification = CustomerContent;
+        }
+        field(5; CMPITQTY; Decimal)
+        {
+            DataClassification = CustomerContent;
+        }
+        field(6; CMPSERNM; Boolean)
+        {
+            DataClassification = CustomerContent;
+        }
+        field(7; DEX_ROW_ID; Integer)
+        {
+            DataClassification = CustomerContent;
+        }
+    }
+    keys
+    {
+        key(Key1; ITEMNMBR, CMPTITNM, CMPITUOM)
+        {
+            Clustered = true;
+        }
+    }
+}