Skip to content

Commit 206662f

Browse files
SatwikKrSharmaSatwik Kumar Sharma
andauthored
Resolved the hyperlink color and <h1> A11y bugs (#9268)
* Resolved the hyperlink color and <h1> A11y bugs * resolving pipeline issues * resolving pipeline issues * resolving pipeline issues * testing pipeline * Delete .pipelines/test-ci.yml * intalling sdk version 17763 * intalling sdk version 17763 * intalling sdk version 18362 * intalling sdk version 19041 * resolving pipeline error --------- Co-authored-by: Satwik Kumar Sharma <satwiksharma@microsoft.com>
1 parent d221988 commit 206662f

File tree

7 files changed

+26
-10
lines changed

7 files changed

+26
-10
lines changed

.pipelines/uwp-ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,14 @@ steps:
5050
targetType: filePath
5151
filePath: source/uwp/Build/GenerateTestPFX.ps1
5252

53+
- task: PowerShell@2
54+
displayName: 'Install Windows SDK'
55+
inputs:
56+
targetType: 'inline'
57+
script: |
58+
choco install windows-sdk-10-version-1809-all
59+
choco install windows-sdk-10-version-2004-all
60+
5361
- task: VSBuild@1
5462
name: VSBuild3
5563
displayName: Build solution

.pipelines/winui3-ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,14 @@ steps:
4343
restoreSolution: $(solution)
4444
verbosityRestore: Detailed
4545

46+
47+
- task: PowerShell@2
48+
displayName: 'Install Windows SDK'
49+
inputs:
50+
targetType: 'inline'
51+
script: |
52+
choco install windows-sdk-10-version-1809-all
53+
4654
- task: VSBuild@1
4755
name: VSBuild4
4856
displayName: Build solution

source/nodejs/adaptivecards-site/themes/adaptivecards/layout/index.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
<div class="w3-center" style="max-width: 600px; margin: auto">
3333
<div class="w3-margin w3-padding-32">
34-
<h1 class="w3-xxlarge"><%- site.data.home.en.heading %></h1>
34+
<h2 class="w3-xxlarge"><%- site.data.home.en.heading %></h2>
3535
<div class="accent-paragraph"><%- site.data.home.en.heading_paragraph %></div>
3636
<div class="w3-padding-16">
3737
<button role="link" onclick="window.location.href='https://docs.microsoft.com/en-us/adaptive-cards/'"

source/nodejs/adaptivecards-site/themes/adaptivecards/source/css/style.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ body > #headerAreaHolder {
3030

3131
.ac-blue {
3232
color: #fff !important;
33-
background-color: #0050c5 !important;
33+
background-color: var(--blue) !important;
3434
}
3535

3636
.breadcrumbs {
@@ -646,19 +646,19 @@ button .fa-check {
646646

647647
.ac-blue {
648648
color: #fff !important;
649-
background-color: #0b78d0 !important;
649+
background-color: var(--blue) !important;
650650
}
651651

652652
.homepage a:link,
653653
.homepage a:visited {
654-
color: #0b78d0;
654+
color: var(--blue);
655655
font-size: 15px;
656656
line-height: 29px;
657657
font-weight: 600;
658658
}
659659

660660
.homepage a:hover {
661-
color: blue;
661+
color: var(--blue-light);
662662
}
663663

664664
.schema-content a:link,

source/uwp/AdaptiveCardsObjectModel/AdaptiveCardsObjectModel.vcxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
4444
<AppContainerApplication>true</AppContainerApplication>
4545
<ApplicationType>Windows Store</ApplicationType>
46-
<WindowsTargetPlatformVersion>10.0.18362.0</WindowsTargetPlatformVersion>
47-
<WindowsTargetPlatformMinVersion>10.0.15063.0</WindowsTargetPlatformMinVersion>
46+
<WindowsTargetPlatformVersion>10.0.19041.0</WindowsTargetPlatformVersion>
47+
<WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
4848
<ApplicationTypeRevision>10.0</ApplicationTypeRevision>
4949
<TargetName>AdaptiveCards.ObjectModel.Uwp</TargetName>
5050
<GenerateManifest>false</GenerateManifest>
@@ -53,7 +53,7 @@
5353
<PlatformToolset Condition="'$(VisualStudioVersion)' == '16.0'">v142</PlatformToolset>
5454
<CppWinRTFastAbi>true</CppWinRTFastAbi>
5555
<CppWinRTOptimized>true</CppWinRTOptimized>
56-
<UseCrtSDKReferenceStaticWarning>false</UseCrtSDKReferenceStaticWarning>
56+
<UseCrtSDKReferenceStaticWarning>false</UseCrtSDKReferenceStaticWarning>
5757
</PropertyGroup>
5858
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
5959
<!-- Build with the Hybrid CRT (Universal CRT + Static VS CRT (for what little the Universal CRT doesn't cover) -->

source/uwp/UWPUITestApp/UWPUITestApp.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<AssemblyName>UWPUITestApp</AssemblyName>
1212
<DefaultLanguage>en-US</DefaultLanguage>
1313
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
14-
<TargetPlatformVersion Condition=" '$(TargetPlatformVersion)' == '' ">10.0.18362.0</TargetPlatformVersion>
14+
<TargetPlatformVersion Condition=" '$(TargetPlatformVersion)' == '' ">10.0.19041.0</TargetPlatformVersion>
1515
<TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
1616
<MinimumVisualStudioVersion>14</MinimumVisualStudioVersion>
1717
<FileAlignment>512</FileAlignment>

source/uwp/UWPUITests/UWPUITests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
<ItemGroup>
2020
<Reference Include="Windows.Foundation.UniversalApiContract">
21-
<HintPath>C:\Program Files (x86)\Windows Kits\10\References\10.0.18362.0\Windows.Foundation.UniversalApiContract\8.0.0.0\Windows.Foundation.UniversalApiContract.winmd</HintPath>
21+
<HintPath>C:\Program Files (x86)\Windows Kits\10\References\10.0.19041.0\Windows.Foundation.UniversalApiContract\10.0.0.0\Windows.Foundation.UniversalApiContract.winmd</HintPath>
2222
</Reference>
2323
</ItemGroup>
2424

0 commit comments

Comments
 (0)