make letsencrypt missing parameters

[damoodamoo]

the make letsencrypt target showed errors in missing:

• STORAGE_ACCOUNT
• FQDN

Supplying them in the command, and giving the user the Contributor to the stweb storage account and Secret Import permissions to the KV, then everything worked.

So my final command was:
STORAGE_ACCOUNT=stweb<tre-id> FQDN=<treid>.<location>.cloudapp.azure.com make letsencrypt

[SvenAelterman]

Ran into this issue today on a renewal.

@damoodamoo Did you encounter this on initial issuance or on renewal?

[marrobi]

@damoodamoo was that in the deployment repo?

Workaround is delete - ./core/tre_output.json as it is either empty or missing some variables. Deleting it results in terraform init being run as part of the `make letsencrpt1 command and the json file is recreated from TF state.

Not sure why the file would be empty, or not have all the variables in the first place.

[damoodamoo]

I'm happy to close this if if can't be repro'd. I believe it would've been in the deployment repo.

[marrobi]

For some reason some deployments end up with an empty tre_output.json file.

A workaround was to add if [ ! -s ../tre_output.json ]; then to line 4 of ./core/terraform/outputs.sh to recreate the file if its empty. Not sure if that's the same issue you hit.

[marrobi]

So confirmed this issue happens if the script fails first time and end up with an empty file.