Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate deploy scripts and remove unused files #4382

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Feb 19, 2025

Consolidate multiple deployment scripts into a single destroy script while removing obsolete deploy scripts to streamline the deployment process.

Remove unused upgrade.sh scripts.

@marrobi marrobi requested a review from Copilot February 19, 2025 15:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 25 out of 44 changed files in this pull request and generated no comments.

Files not reviewed (19)
  • Makefile: Language not supported
  • core/terraform/deploy.sh: Language not supported
  • core/terraform/destroy.sh: Language not supported
  • core/terraform/import.sh: Language not supported
  • devops/scripts/terraform_deploy.sh: Language not supported
  • devops/scripts/terraform_wrapper.sh: Language not supported
  • templates/shared_services/admin-vm/.dockerignore: Language not supported
  • templates/shared_services/admin-vm/terraform/deploy.sh: Language not supported
  • templates/shared_services/airlock_notifier/terraform/deploy.sh: Language not supported
  • templates/shared_services/cyclecloud/terraform/deploy.sh: Language not supported
  • templates/shared_services/databricks-auth/.dockerignore: Language not supported
  • templates/shared_services/databricks-auth/terraform/deploy.sh: Language not supported
  • templates/shared_services/deploy_from_local.sh: Language not supported
  • templates/shared_services/gitea/terraform/deploy.sh: Language not supported
  • templates/shared_services/sonatype-nexus-vm/terraform/deploy.sh: Language not supported
  • templates/workspace_services/azureml/terraform/deploy.sh: Language not supported
  • templates/workspace_services/azureml/terraform/upgrade.sh: Language not supported
  • templates/workspace_services/azureml/user_resources/aml_compute/terraform/deploy.sh: Language not supported
  • templates/workspace_services/azureml/user_resources/aml_compute/terraform/upgrade.sh: Language not supported
Copy link

github-actions bot commented Feb 19, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 10f0713.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Feb 20, 2025

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13432103264 (with refid 566bd2d4)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 20, 2025

/test-destroy-env

Passed.

Copy link

Destroying PR test environment (RG: rg-tre566bd2d4)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13434081929)

Copy link

PR test environment destroy complete (RG: rg-tre566bd2d4)

@marrobi marrobi requested a review from jonnyry February 20, 2025 12:49
Copy link
Collaborator

@yuvalyaron yuvalyaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@marrobi
Copy link
Member Author

marrobi commented Feb 27, 2025

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13562243756 (with refid 566bd2d4)

(in response to this comment from @marrobi)

Copy link
Collaborator

@ShakutaiGit ShakutaiGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi
Copy link
Member Author

marrobi commented Feb 27, 2025

/tre-destroy-env

@marrobi
Copy link
Member Author

marrobi commented Feb 27, 2025

/help

Copy link

🤖 pr-bot 🤖

/tre-destroy-env is not recognised as a valid command.

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 27, 2025

/test-destroy-env

Copy link

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @marrobi)

Copy link

Destroying PR test environment (RG: rg-tre566bd2d4)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13570381217)

Copy link

PR test environment destroy complete (RG: rg-tre566bd2d4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants