Skip to content

Prevent nodes added during a rolled back reconfiguration from disrupting the service #3985

@heidihoward

Description

@heidihoward

It is my understanding that newly added nodes begin ticking (see: https://github.com/microsoft/CCF/blob/src/consensus/aft/raft.h#L1305) and thus can become a candidate when their reconfiguration txn becomes committable (followed by a signature txn). If the reconfiguration is then rolled back, then the newly added nodes will timeout, repeatedly trying to become a leader, and thus disrupt the active configuration.

One possible solution is to require newly added nodes (nodes who have not yet seen the reconfiguration txn which added them be committed) to check the status of the reconfiguration txn before starting an election. If the reconfiguration txn is invalid, then they can safety shut down.

This is low priority as it is hypothetical and could only impact liveness if a reconfiguration is unsuccessful. This could also be fixed by PreVote (#2577).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions