Skip to content

Commit 59a2d23

Browse files
Update README to emphasize built-in filters are add automatically and adjust wording (#448)
* update README * remove unused reference
1 parent fca557a commit 59a2d23

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ If all of three filters are registered:
533533

534534
## Built-In Feature Filters
535535

536-
There a few feature filters that come with the `Microsoft.FeatureManagement` package: `PercentageFilter`, `TimeWindowFilter`, `ContextualTargetingFilter` and `TargetingFilter`. All filters, except for the `TargetingFilter`, are added automatically when feature management is registered. The `TargetingFilter` is added with the `WithTargeting` method that is detailed in the `Targeting` section below.
536+
There a few feature filters that come with the `Microsoft.FeatureManagement` package: `PercentageFilter`, `TimeWindowFilter`, `ContextualTargetingFilter` and `TargetingFilter`. All filters, except for the `TargetingFilter`, are added **automatically** when feature management is registered by `AddFeatureManagement` method. The `TargetingFilter` is added with the `WithTargeting` method that is detailed in the `Targeting` section below.
537537

538538
Each of the built-in feature filters have their own parameters. Here is the list of feature filters along with examples.
539539

@@ -603,7 +603,7 @@ The `Recurrence` settings is made up of two parts: `Pattern` (how often the time
603603

604604
#### Recurrence Pattern
605605

606-
There are two possible recurrence pattern types: `Daily` and `Weekly`. For example, a time window could repeat "every day", "every 3 days", "every Monday" or "on Friday per 2 weeks".
606+
There are two possible recurrence pattern types: `Daily` and `Weekly`. For example, a time window could repeat "every day", "every 3 days", "every Monday" or "every other Friday".
607607

608608
Depending on the type, certain fields of the `Pattern` are required, optional, or ignored.
609609

src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFilter.cs

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Microsoft.Extensions.Logging;
66
using Microsoft.Extensions.Options;
77
using System;
8-
using System.Collections.Generic;
98
using System.Linq;
109
using System.Security.Cryptography;
1110
using System.Text;

0 commit comments

Comments
 (0)