Skip to content

Commit 3d8a277

Browse files
author
Werner Henze
committed
remove all test that previously did not fail, but now fail
It would be better to keep those tests, but I cannot get them to compile.
1 parent 6350455 commit 3d8a277

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

tests/byte_tests.cpp

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@
1919
#define GSL_USE_STD_BYTE 0
2020
#include <gsl/byte> // for to_byte, to_integer, byte, operator&, ope...
2121

22-
#include <type_traits>
23-
#include <utility>
24-
2522
using namespace std;
2623
using namespace gsl;
2724

@@ -131,24 +128,6 @@ TEST(byte_tests, aliasing)
131128
EXPECT_TRUE(res == i);
132129
}
133130

134-
// These are regressions, should be fixed.
135-
static_assert(std::is_void_v<std::void_t<decltype(operator<< <float, void>(gsl::byte{}, float{}))>>,
136-
"operator<<(byte, float) compiles");
137-
static_assert(std::is_void_v<std::void_t<decltype(operator>> <float, void>(gsl::byte{}, float{}))>>,
138-
"operator>>(byte, float) compiles");
139-
static_assert(
140-
std::is_void_v<
141-
std::void_t<decltype(operator<<= <float, void>(std::declval<gsl::byte&>(), float{}))>>,
142-
"operator<<=(byte, float) compiles");
143-
static_assert(
144-
std::is_void_v<
145-
std::void_t<decltype(operator>>= <float, void>(std::declval<gsl::byte&>(), float{}))>>,
146-
"operator>>=(byte, float) compiles");
147-
static_assert(std::is_floating_point_v<decltype(to_integer<float, float>(gsl::byte(0)))>,
148-
"gsl::byte converts to float");
149-
static_assert(std::is_floating_point_v<decltype(to_integer<float, float>(gsl::byte(0)))>,
150-
"gsl::byte converts to float");
151-
152131
} // namespace
153132

154133
#ifdef CONFIRM_COMPILATION_ERRORS

tests/pointers_tests.cpp

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@
33
#include <gsl/pointers>
44

55
#include <memory>
6-
#include <type_traits>
7-
#include <utility>
8-
9-
namespace
10-
{
116

127
TEST(pointers_test, swap)
138
{
@@ -24,15 +19,3 @@ TEST(pointers_test, swap)
2419
EXPECT_TRUE(*b == 0);
2520
}
2621

27-
// These are regressions, should be fixed.
28-
struct NotMovable
29-
{
30-
NotMovable(NotMovable&&) = delete;
31-
NotMovable& operator=(NotMovable&&) = delete;
32-
};
33-
using NotNull_NotMovable = gsl::not_null<NotMovable>;
34-
static_assert(std::is_void_v<std::void_t<decltype(gsl::swap<NotMovable, void>(
35-
std::declval<NotNull_NotMovable&>(), std::declval<NotNull_NotMovable&>()))>>,
36-
"gsl::swap(NotNull_NotMovable, NotNull_NotMovable) compiles");
37-
38-
} // namespace

0 commit comments

Comments
 (0)