Merge pull request #777 from jeschu1/nullcheck

jeschu1 · web-flow · commit 906745dcf426 · 2018-10-09T12:30:47.000-04:00
devops: fix null reference if no parameter exists
diff --git a/AzureDevOps.Authentication/Src/Authentication.cs b/AzureDevOps.Authentication/Src/Authentication.cs
@@ -238,7 +238,7 @@ public override async Task<bool> DeleteCredentials(TargetUri targetUri)
 
                                         var value = header.Parameter;
 
-                                        if (value.Length >= AuthorizationUriPrefix.Length + AuthorityHostUrlBase.Length + GuidStringLength)
+                                        if (value?.Length >= AuthorizationUriPrefix.Length + AuthorityHostUrlBase.Length + GuidStringLength)
                                         {
                                             // The header parameter will look something like "authorization_uri=https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47"
                                             // and all we want is the portion after the '=' and before the last '/'.

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ public override async Task<bool> DeleteCredentials(TargetUri targetUri)`
`238`	`238`
`239`	`239`	`var value = header.Parameter;`
`240`	`240`
`241`		`- if (value.Length >= AuthorizationUriPrefix.Length + AuthorityHostUrlBase.Length + GuidStringLength)`
	`241`	`+ if (value?.Length >= AuthorizationUriPrefix.Length + AuthorityHostUrlBase.Length + GuidStringLength)`
`242`	`242`	`{`
`243`	`243`	`// The header parameter will look something like "authorization_uri=https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47"`
`244`	`244`	`// and all we want is the portion after the '=' and before the last '/'.`