Skip to content

Commit 7ff2007

Browse files
committed
Fix the KS Abstraction pin enumeration that I broke :)
1 parent f316cbd commit 7ff2007

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/api/Abstraction/KSAbstraction/Midi2.KSMidiEndpointManager.cpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -638,19 +638,17 @@ CMidi2KSMidiEndpointManager::OnDeviceAdded(
638638
{
639639
TraceLoggingWrite(
640640
MidiKSAbstractionTelemetryProvider::Provider(),
641-
MIDI_TRACE_EVENT_ERROR,
641+
MIDI_TRACE_EVENT_INFO,
642642
TraceLoggingString(__FUNCTION__, MIDI_TRACE_EVENT_LOCATION_FIELD),
643-
TraceLoggingLevel(WINEVENT_LEVEL_ERROR),
643+
TraceLoggingLevel(WINEVENT_LEVEL_INFO),
644644
TraceLoggingPointer(this, "this"),
645-
TraceLoggingWideString(L"Pin is regular unidirectional MIDI pin. Aborting creation.", MIDI_TRACE_EVENT_MESSAGE_FIELD),
645+
TraceLoggingWideString(L"Pin is unidirectional", MIDI_TRACE_EVENT_MESSAGE_FIELD),
646646
TraceLoggingWideString(MidiPin->Name.c_str(), "pin name")
647647
);
648648

649-
RETURN_IF_FAILED(E_UNEXPECTED);
650-
651-
//// In and out have only a single pin id to create.
652-
//interfaceDevProperties.push_back({ { DEVPKEY_KsMidiPort_KsPinId, DEVPROP_STORE_SYSTEM, nullptr },
653-
// DEVPROP_TYPE_UINT32, static_cast<ULONG>(sizeof(UINT32)), &(MidiPin->PinId) });
649+
// In and out have only a single pin id to create.
650+
interfaceDevProperties.push_back({ { DEVPKEY_KsMidiPort_KsPinId, DEVPROP_STORE_SYSTEM, nullptr },
651+
DEVPROP_TYPE_UINT32, static_cast<ULONG>(sizeof(UINT32)), &(MidiPin->PinId) });
654652
}
655653

656654
//deviceDevProperties.push_back({ { DEVPKEY_Device_PresenceNotForDevice, DEVPROP_STORE_SYSTEM, nullptr },

0 commit comments

Comments
 (0)