Fix the KS Abstraction pin enumeration that I broke :)

microsoft · Jul 31, 2024 · 7ff2007 · 7ff2007
1 parent f316cbd
commit 7ff2007
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/api/Abstraction/KSAbstraction/Midi2.KSMidiEndpointManager.cpp b/src/api/Abstraction/KSAbstraction/Midi2.KSMidiEndpointManager.cpp
@@ -638,19 +638,17 @@ CMidi2KSMidiEndpointManager::OnDeviceAdded(
         {
             TraceLoggingWrite(
                 MidiKSAbstractionTelemetryProvider::Provider(),
-                MIDI_TRACE_EVENT_ERROR,
+                MIDI_TRACE_EVENT_INFO,
                 TraceLoggingString(__FUNCTION__, MIDI_TRACE_EVENT_LOCATION_FIELD),
-                TraceLoggingLevel(WINEVENT_LEVEL_ERROR),
+                TraceLoggingLevel(WINEVENT_LEVEL_INFO),
                 TraceLoggingPointer(this, "this"),
-                TraceLoggingWideString(L"Pin is regular unidirectional MIDI pin. Aborting creation.", MIDI_TRACE_EVENT_MESSAGE_FIELD),
+                TraceLoggingWideString(L"Pin is unidirectional", MIDI_TRACE_EVENT_MESSAGE_FIELD),
                 TraceLoggingWideString(MidiPin->Name.c_str(), "pin name")
             );
 
-            RETURN_IF_FAILED(E_UNEXPECTED);
-
-            //// In and out have only a single pin id to create.
-            //interfaceDevProperties.push_back({ { DEVPKEY_KsMidiPort_KsPinId, DEVPROP_STORE_SYSTEM, nullptr },
-            //    DEVPROP_TYPE_UINT32, static_cast<ULONG>(sizeof(UINT32)), &(MidiPin->PinId) });
+            // In and out have only a single pin id to create.
+            interfaceDevProperties.push_back({ { DEVPKEY_KsMidiPort_KsPinId, DEVPROP_STORE_SYSTEM, nullptr },
+                DEVPROP_TYPE_UINT32, static_cast<ULONG>(sizeof(UINT32)), &(MidiPin->PinId) });
         }
 
         //deviceDevProperties.push_back({ { DEVPKEY_Device_PresenceNotForDevice, DEVPROP_STORE_SYSTEM, nullptr },