Skip to content

Commit 5e76345

Browse files
authored
Merge pull request #9085 from keveleigh/revert-oculushand
Revert "Merge pull request #9075 from RogPodge/oculushandrayfix" for 2.5.3
2 parents 2df82e4 + 8dbf53c commit 5e76345

File tree

8 files changed

+16
-14
lines changed

8 files changed

+16
-14
lines changed

Assets/MRTK/Providers/Oculus/XRSDK/MRTK-Quest/Scripts/Input/Controllers/OculusHand.cs

-3
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,6 @@ protected bool IsInTeleportPose
182182
}
183183
}
184184

185-
/// <inheritdoc/>
186-
public override bool IsInPointingPose => handDefinition.IsInPointingPose;
187-
188185
protected bool IsPinching { set; get; }
189186

190187
// Pinch was also used as grab, we want to allow hand-curl grab not just pinch.

Assets/MRTK/Tests/EditModeTests/Core/Utilities/BuildAndDeploy/UwpAppxBuildToolsTest.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class UwpAppxBuildToolsTest
2626
xmlns:mobile='http://schemas.microsoft.com/appx/manifest/mobile/windows10'
2727
IgnorableNamespaces='uap uap2 uap3 uap4 mp mobile iot'
2828
xmlns='http://schemas.microsoft.com/appx/manifest/foundation/windows10'>
29-
<Identity Name='Microsoft.MixedReality.Toolkit' Publisher='CN=Microsoft' Version='2.5.2.0' />
29+
<Identity Name='Microsoft.MixedReality.Toolkit' Publisher='CN=Microsoft' Version='2.5.3.0' />
3030
<mp:PhoneIdentity PhoneProductId='85c8bcd4-fbac-44ed-adf6-bfc01242a27f' PhonePublisherId='00000000-0000-0000-0000-000000000000' />
3131
<Properties>
3232
<DisplayName>MixedRealityToolkit</DisplayName>

Documentation/Contributing/Roadmap.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This document outlines the roadmap of the Mixed Reality Toolkit. Please note tha
44

55
## Current release
66

7-
[Microsoft Mixed Reality Toolkit v2.5.2](https://github.com/Microsoft/MixedRealityToolkit-Unity/releases/tag/v2.5.2)
7+
[Microsoft Mixed Reality Toolkit v2.5.3](https://github.com/Microsoft/MixedRealityToolkit-Unity/releases/tag/v2.5.3)
88

99
## Upcoming releases
1010

Documentation/ReleaseNotes.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Microsoft Mixed Reality Toolkit 2.5.2 release notes
1+
# Microsoft Mixed Reality Toolkit 2.5.3 release notes
22

33
- [What's new](#whats-new)
44
- [Updating guidance](Updating.md#upgrading-to-a-new-version-of-mrtk)
@@ -11,6 +11,10 @@
1111
1212
## What's new
1313

14+
### Fixes a regression with Oculus introduced in 2.5.2
15+
16+
2.5.2 introduced [a build issue when integrating the Oculus SDK](https://github.com/microsoft/MixedRealityToolkit-Unity/issues/9083). This release reverts that issue.
17+
1418
### Add support for OpenXR
1519

1620
Initial support for Unity's OpenXR preview package and Microsoft's Mixed Reality OpenXR package has been added. See [the MRTK/XRSDK getting started page](GettingStartedWithMRTKAndXRSDK.md), [Unity's forum post](https://forum.unity.com/threads/unity-support-for-openxr-in-preview.1023613/), or [Microsoft's documentation](https://aka.ms/openxr-unity-install) for more information.
@@ -26,7 +30,7 @@ Boundary visualizations, like the floor or walls, will now be properly configure
2630

2731
### MSBuild for Unity support
2832

29-
Support for MSBuild for Unity has been removed in the 2.5.2 release, to align with [Unity's new package guidance](https://forum.unity.com/threads/updates-to-our-terms-of-service-and-new-package-guidelines.999940/).
33+
Support for MSBuild for Unity has been removed as of the 2.5.2 release, to align with [Unity's new package guidance](https://forum.unity.com/threads/updates-to-our-terms-of-service-and-new-package-guidelines.999940/).
3034

3135
## Known issues
3236

Documentation/usingupm.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ To add an MRTK package, modify the dependencies section of the `Packages/manifes
4242

4343
```json
4444
"dependencies": {
45-
"com.microsoft.mixedreality.toolkit.foundation": "2.5.2",
46-
"com.microsoft.mixedreality.toolkit.tools": "2.5.2",
47-
"com.microsoft.mixedreality.toolkit.examples": "2.5.2",
45+
"com.microsoft.mixedreality.toolkit.foundation": "2.5.3",
46+
"com.microsoft.mixedreality.toolkit.tools": "2.5.3",
47+
"com.microsoft.mixedreality.toolkit.examples": "2.5.3",
4848
```
4949

5050
> [!IMPORTANT]

ProjectSettings/ProjectSettings.asset

+2-2
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ PlayerSettings:
118118
16:10: 1
119119
16:9: 1
120120
Others: 1
121-
bundleVersion: 2.5.2
121+
bundleVersion: 2.5.3
122122
preloadedAssets: []
123123
metroInputSource: 0
124124
wsaTransparentSwapchain: 0
@@ -687,7 +687,7 @@ PlayerSettings:
687687
m_RenderingPath: 1
688688
m_MobileRenderingPath: 1
689689
metroPackageName: Microsoft.MixedReality.Toolkit
690-
metroPackageVersion: 2.5.2.0
690+
metroPackageVersion: 2.5.3.0
691691
metroCertificatePath: Assets/WSATestCertificate.pfx
692692
metroCertificatePassword:
693693
metroCertificateSubject: Microsoft

pipelines/config/settings.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ variables:
1111
# match (see scripts/packaging/versionmetadata.ps1)
1212
# ProjectSettings/ProjectSettings.asset: bundleVersion: x.x.x
1313
# ProjectSettings/ProjectSettings.asset: metroPackageVersion: x.x.x.0
14-
MRTKVersion: 2.5.2
14+
MRTKVersion: 2.5.3
1515
MRTKReleaseTag: '' # final version component, e.g. 'RC2.1' or empty string
1616
ToolsRepoName: mixedrealitytoolkit.build
1717
ToolsDir: $(Build.SourcesDirectory)\$(ToolsRepoName)

scripts/docs/web/version.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
function createDropdown()
22
{
33
// configurable values:
4-
var defaultTitle = "releases/2.5.2"; // title in the dropdown for the root version of the docs - alternatively put a version from the version array as a default
4+
var defaultTitle = "releases/2.5.3"; // title in the dropdown for the root version of the docs - alternatively put a version from the version array as a default
55

66
// list of all versions in the version folder
77
var versionArray = [
@@ -14,6 +14,7 @@ function createDropdown()
1414
"releases/2.5.0",
1515
"releases/2.5.1",
1616
"releases/2.5.2",
17+
"releases/2.5.3",
1718
];
1819

1920
var ignoreDefaultInVersionFolder = true;

0 commit comments

Comments
 (0)