Skip to content

Revisit KBM test methods: unrelated change caused failure #14596

Open
@crutkas

Description

Microsoft PowerToys version

0.51

Running as admin

  • Yes

Area(s) with issue?

Keyboard Manager

Steps to reproduce

From #14591, a change causes these to start throwing ShortcutErrorType::ShortcutCannotHaveRepeatedModifier from BufferValidationHelpers.cpp but with the change of just going from double modifier to triple modifier.

The change should not have caused this ripple effect.

ValidateShortcutBufferElement_ShouldReturnShortcutMaxShortcutSizeOneActionKeyErrorAndNoAction_OnSettingLastDropDownToRepeatedModifierKeyOnAColumnIfThereAre3OrMoreDropDowns
ValidateShortcutBufferElement_ShouldReturnShortcutMaxShortcutSizeOneActionKeyErrorAndNoAction_OnSettingLastDropDownToNonRepeatedModifierKeyOnAColumnIfThereAre3OrMoreDropDowns

✔️ Expected Behavior

test should have chances are failed but not with that failure

❌ Actual Behavior

failed with duplicate key error

Other Software

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    • Status

      No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions