forms #31828

Jay-o-Way · 2024-03-10T14:21:10Z

Summary of the Pull Request

Overhaul of issue forms to (hopefully) be more functional.

PR Checklist

Closes: (suggestions to) improve issue forms #31790
Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected

Detailed Description of the Pull Request / Additional comments

removed one entry for MSRC
added checklists, to make users more aware
added ids - these should work for Improve the 'report bug' functionality to auto-fill in critical bug data (like DevHome) #31797
split improvement request and new feature request
rephrased and re-arranged (required first) items

Validation Steps Performed

Impossible :(

change description spell-check move validations note "here"

Aaron-Junker

Two little things.

Aaron-Junker · 2024-03-10T18:26:45Z

.github/ISSUE_TEMPLATE/bug_report.yml

+      options:
+        - "Yes"
+        - "No"


This has to be marked as required, otherwise you can choose "None"

"none" means no selection, it's not a literal option

"none" means no selection, it's not a literal option

Yes, but I think if you mark it as required this option will be unavailable.

Aaron-Junker · 2024-03-10T18:28:17Z

.github/ISSUE_TEMPLATE/bug_report.yml

+  - type: checkboxes
+    attributes:
+      label: Include the Bug Report
+      description: "Right-click on our system tray icon and select **Bug Report**. Then upload the zip file from your desktop: Paste, drop or click to add files."
+      options:
+        - label: I have attached the Bug Report file
+          required: true


I think the previous text was sufficient. There are a lot of scenarios where including a bug report is not an option (installer issues for example).

I suppose I can make required: false.

crutkas · 2024-03-11T03:37:39Z

.github/ISSUE_TEMPLATE/bug_report.yml

-    description: Hover over system tray icon or look at Settings
-  validations:
-    required: true
+  - type: checkboxes


I don't agree with this. I don't like it when others do it and i honestly doubt it will change any behavior. With some of the things getting tested out, i bet we we'll improve alerting for duplicates as well based on results from other repos.

Yes the bot is nice. But a waste of time if we can prevent duplicates.

crutkas · 2024-03-11T03:38:49Z

.github/ISSUE_TEMPLATE/bug_report.yml

-      - "No"
+  - type: dropdown
+    attributes:
+      label: Running as Administrator?


Suggested change

label: Running as Administrator?

label: Running PowerToys as Administrator?

crutkas · 2024-03-11T03:39:52Z

.github/ISSUE_TEMPLATE/bug_report.yml

-    placeholder: What were you expecting?
-  validations:
-    required: false
+  - type: checkboxes


Combine this with a Steps to reproduce. It isn't always needed

crutkas · 2024-03-11T03:41:48Z

.github/ISSUE_TEMPLATE/documentation-issue.yml

  validations:
    required: true
+  attributes: 
+    label: Provide a description of requested docs changes
+    description: Describe which document needs to be corrected and why.


I feel the other has a softer tone.

Suggested change

description: Describe which document needs to be corrected and why.

description: Briefly describe which document needs to be corrected and why you feel this way.

crutkas · 2024-03-11T03:42:21Z

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,26 +1,46 @@
-name: "⭐ Feature or enhancement request"


i do not want to split

crutkas · 2024-03-11T03:42:46Z

.github/ISSUE_TEMPLATE/translation_issue.yml

- Needs-Triage
+description: Report incorrect translations
+labels: [Needs-Triage, Issue-Bug, Issue-Translation, Area-Localization]
+assignees: crutkas


Why? As far as I know (let me know if I'm wrong) you're the only link between this repo and the translation team? That makes it "by definition" your task.

crutkas · 2024-03-11T03:43:08Z

.github/ISSUE_TEMPLATE/translation_issue.yml

+  - type: checkboxes
+    id: preparation
+    attributes:
+      label: Before filing a new issue, please check the following
+      description: This makes it easier for us all :)
+      options:
+        - label: I am using the latest version (check for updates in Settings)
+          required: true
+        - label: I have searched in [open issues](https://github.com/microsoft/PowerToys/issues) (remember to try different search terms)
+          required: true
+        - label: I have searched in [closed issues](https://github.com/microsoft/PowerToys/issues?q=is%3Aissue+is%3Aclosed) (there might be a good reason)
+          required: true


crutkas · 2024-03-11T03:43:28Z

.github/ISSUE_TEMPLATE/feature_request.yml

+  - type: checkboxes
+    id: preparation
+    attributes:
+      label: Before filing a new issue, please check the following
+      description: This makes it easier for us all :)
+      options:
+        - label: I am using the latest version (check for updates in Settings)
+          required: true
+        - label: I have searched the [online documentation](https://aka.ms/PowerToysOverview)
+          required: true
+        - label: I have searched in [open issues](https://github.com/microsoft/PowerToys/issues) (remember to try different search terms)
+          required: true
+        - label: I have searched in [closed issues](https://github.com/microsoft/PowerToys/issues?q=is%3Aissue+is%3Aclosed) (there might be a good reason)
+          required: true


crutkas · 2024-03-11T03:44:01Z

.github/ISSUE_TEMPLATE/bug_report.yml

+  - type: checkboxes
+    id: preparation
+    attributes:
+      label: Before filing a new issue, please check the following
+      description: This makes it easier for us all :)
+      options:
+        - label: I am using the latest version (check for updates in Settings)
+          required: true
+        - label: I have searched the [online documentation](https://aka.ms/PowerToysOverview)
+          required: true
+        - label: I have searched in [open issues](https://github.com/microsoft/PowerToys/issues) (remember to try different search terms)
+          required: true
+        - label: I have searched in [closed issues](https://github.com/microsoft/PowerToys/issues?q=is%3Aissue+is%3Aclosed) (there might be a good reason)
+          required: true


crutkas · 2024-03-11T03:45:24Z

.github/ISSUE_TEMPLATE/translation_issue.yml

+  - type: textarea
+    id: displayedtext
+    validations:
+      required: true
+    attributes:
+      label: ❌ Displayed text
+      description: Please include a screenshot as that is extremely helpful.
+
+  - type: textarea
+    id: correcttext
+    validations:
+      required: true
+    attributes:
+      label: ✔️ Correct text
+
+  - type: textarea
+    id: context
+    validations:
+      required: true
+    attributes:
+      label: ℹ Context, explanation


the prior body here was more user friendly, i prefer the other tone. please revert

forms

ed969f0

Jay-o-Way requested review from Aaron-Junker, htcfreek and ethanfangg March 10, 2024 14:22

This comment has been minimized.

Sign in to view

Jay-o-Way added the Area-GitHub workflow Issues regarding the GitHub workflow and automation label Mar 10, 2024

Jay-o-Way marked this pull request as ready for review March 10, 2024 15:06

adjustments

b0c909c

change description spell-check move validations note "here"

Aaron-Junker requested changes Mar 10, 2024

View reviewed changes

crutkas requested changes Mar 11, 2024

View reviewed changes

Jay-o-Way closed this Apr 13, 2024

Jay-o-Way deleted the Issue-forms branch April 14, 2024 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

forms #31828

forms #31828

Jay-o-Way commented Mar 10, 2024 •

edited

Loading

This comment has been minimized.

Aaron-Junker left a comment

Aaron-Junker Mar 10, 2024

Jay-o-Way Mar 10, 2024

Aaron-Junker Mar 10, 2024

Aaron-Junker Mar 10, 2024

Jay-o-Way Mar 10, 2024

crutkas Mar 11, 2024

Jay-o-Way Apr 13, 2024

crutkas Mar 11, 2024

crutkas Mar 11, 2024

crutkas Mar 11, 2024

crutkas Mar 11, 2024

crutkas Mar 11, 2024

Jay-o-Way Apr 13, 2024

crutkas Mar 11, 2024

crutkas Mar 11, 2024

crutkas Mar 11, 2024

crutkas Mar 11, 2024

	label: Running as Administrator?
	label: Running PowerToys as Administrator?

	description: Describe which document needs to be corrected and why.
	description: Briefly describe which document needs to be corrected and why you feel this way.

forms #31828

forms #31828

Conversation

Jay-o-Way commented Mar 10, 2024 • edited Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This comment has been minimized.

Aaron-Junker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jay-o-Way commented Mar 10, 2024 •

edited

Loading