some $-patterns shift counter {} by one character in renamed filename

[frameworker2]

Microsoft PowerToys version

0.79.0

Installation method

PowerToys auto-update

Running as admin

No

Area(s) with issue?

PowerRename

Steps to reproduce

search: .* + enable use regex
replace: <patterns as described below>

✔️ Expected Behavior

All examples for file created March 10th 2024. File is first file in batch ({}->0)
replace: <pattern> -> <result>
replace: $YY${}ABC -> 240ABC
replace: $YYYY${}ABC -> 20240ABC
replace: $MM${}ABC -> 030ABC
replace: $MMM${}ABC -> Mar0ABC
replace: $DD${}ABC -> 100ABC
replace: $DDD${}ABC -> Sun0ABC
replace: $DDDD${}ABC -> Sunday0ABC
replace: $YY$MM$DD${}ABC -> 2403100ABC

❌ Actual Behavior

for each of the named $ pattern the counter is shifted back by one character.
replace: $YY${}ABC -> 24A0BC
replace: $YYYY${}ABC -> 2024A0BC
replace: $MM${}ABC -> 03A0BC
replace: $MMM${}ABC -> MarA0BC
replace: $DD${}ABC -> 10A0BC
replace: $DDD${}ABC -> SunA0BC
replace: $DDDD${}ABC -> Sunda0yABC
replace: $YY$MM$DD${}ABC -> 240310ABC0

Other Software

No response

[Jay-o-Way]

Hm, that's not good. Would you mind sharing a screenshot of the entire window? This might help understand the situation a bit better. (File names, settings, etc)

[frameworker2]

sure.

[Jay-o-Way]

@yuyoyuppe you worked on the counter code, right? We've seen a couple of similar issues (so this might be a duplicate) and there is/are a significant problem when using both the $date and the $counter variables. This is important to pick up. Shall I assign you?
My guess is that there's something miscalculating the offset, but you surely understand the code better then I do.

[yuyoyuppe]

you're correct, thanks, I'll take a look!