Quick Accent does not have ς

[IamSmeagol]

Description of the new feature / enhancement

When pressing lowercase "s" with arrow keys or spacebar the end of word lowercase sigma ( ς ) should also appear alongside σ

Scenario when this would be used?

This is useful for people typing in Greek who wish to have this as an option

Supporting information

No response

[IamSmeagol]

I made a string change in a fork that should resolve this, but I am unfamiliar with tests etc which are requested for a PR

[PesBandi]

Hi @IamSmeagol, don't worry, running tests is relatively easy.

1. Open the solution in Visual Studio as if you were going to build it
2. In the top bar click on Test > Run All Tests or press Ctrl+R, A
3. Wait until the test finish (this will take a while). It is likely that build errors will occur or that some of the test will fail. If that is the case don't hesitate to contact me, I'd be happy to help :)

[IamSmeagol]

Thanks for replying @PesBandi !

I tried syncing my repo to the original then cloning it. I chose to skip the cmake integration since I didn't know how to set it up But when I tried to build and test it said that the build failed.

I decided to clone the original without any changes and ask for help on what I should do at this step. Any advice is appreciated.

I tried building my change after forking and I got build errors. I am using Visual Studio 2022.

Severity Code Description Project File Line Suppression State Details
Warning (active) NETSDK1210 IsAotCompatible and EnableAotAnalyzer are not supported for the target framework. Consider multi-targeting to a supported framework to enable ahead-of-time compilation analysis, and set IsAotCompatible only for the supported frameworks. For example:
true FilePreviewCommon, HostsUILib, MarkdownPreviewHandler, Peek.UI, PowerAccent.Core C:\Program Files\dotnet\sdk\8.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets 90
Error (active) NETSDK1207 Ahead-of-time compilation is not supported for the target framework. UITestAutomation C:\Program Files\dotnet\sdk\8.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets 90
Error (active) NETSDK1209 The current Visual Studio version does not support targeting .NET 9.0. Either target .NET 8.0 or lower, or use Visual Studio version 17.12 or higher AdvancedPaste, AdvancedPaste.UnitTests, AllExperiments, Awake, ColorPickerUI, Common.UI, Community.PowerToys.Run.Plugin.UnitConverter, Community.PowerToys.Run.Plugin.UnitConverter.UnitTest, Community.PowerToys.Run.Plugin.ValueGenerator, Community.PowerToys.Run.Plugin.ValueGenerator.UnitTests, Community.PowerToys.Run.Plugin.VSCodeWorkspaces, Community.PowerToys.Run.Plugin.WebSearch, EnvironmentVariables, EnvironmentVariablesUILib, FancyZonesEditor, FancyZonesEditorCommon, FileLocksmithUI, FilePreviewCommon, GcodePreviewHandler, GcodeThumbnailProvider, GPOWrapperProjection, Hosts, Hosts.Tests, HostsUILib, ImageResizerUI, ImageResizerUITest, KeyboardManagerEditorUI, ManagedCommon, ManagedTelemetry, MarkdownPreviewHandler, MeasureToolUI, Microsoft.Interop.Tests, Microsoft.Plugin.Folder, Microsoft.Plugin.Folder.UnitTests, Microsoft.Plugin.Indexer, Microsoft.Plugin.Program, Microsoft.Plugin.Program.UnitTests, Microsoft.Plugin.Shell, Microsoft.Plugin.Uri, Microsoft.Plugin.Uri.UnitTests, Microsoft.Plugin.WindowsTerminal.UnitTests, Microsoft.Plugin.WindowWalker, Microsoft.Plugin.WindowWalker.UnitTests, Microsoft.PowerToys.Run.Plugin.Calculator, Microsoft.PowerToys.Run.Plugin.Calculator.UnitTest, Microsoft.PowerToys.Run.Plugin.History, Microsoft.PowerToys.Run.Plugin.OneNote, Microsoft.PowerToys.Run.Plugin.PowerToys, Microsoft.PowerToys.Run.Plugin.Registry, Microsoft.PowerToys.Run.Plugin.Registry.UnitTests, Microsoft.PowerToys.Run.Plugin.Service, Microsoft.PowerToys.Run.Plugin.System, Microsoft.PowerToys.Run.Plugin.System.UnitTests, Microsoft.PowerToys.Run.Plugin.TimeDate, Microsoft.PowerToys.Run.Plugin.TimeDate.UnitTests, Microsoft.PowerToys.Run.Plugin.WindowsSettings, Microsoft.PowerToys.Run.Plugin.WindowsTerminal, MonacoPreviewHandler, MouseJump.Common, MouseJump.Common.UnitTests, MouseJumpUI, MouseWithoutBorders, MouseWithoutBorders.UnitTests, MouseWithoutBordersHelper, MouseWithoutBordersService, PdfPreviewHandler, PdfThumbnailProvider, Peek.Common, Peek.FilePreviewer, Peek.UI, PowerAccent.Core, PowerAccent.UI, PowerLauncher, PowerLauncher.Telemetry, PowerOCR, PowerToys.Settings, PowerToys.Settings.DSC.Schema.Generator, PreviewHandlerCommon, QoiPreviewHandler, QoiThumbnailProvider, RegistryPreview, RegistryPreviewUILib, Settings.UI.Library, Settings.UI.UnitTests, StlThumbnailProvider, SvgPreviewHandler, SvgThumbnailProvider, UITestAutomation, UITests-FancyZones, UITests-FancyZonesEditor, UnitTest-ColorPickerUI, UnitTests-FancyZonesEditor, UnitTests-GcodePreviewHandler, UnitTests-GcodeThumbnailProvider, UnitTests-MarkdownPreviewHandler, UnitTests-PdfPreviewHandler, UnitTests-PdfThumbnailProvider, UnitTests-PreviewHandlerCommon, UnitTests-QoiPreviewHandler, UnitTests-QoiThumbnailProvider, UnitTests-StlThumbnailProvider, UnitTests-SvgPreviewHandler, UnitTests-SvgThumbnailProvider, WorkspacesCsharpLibrary, WorkspacesEditor, WorkspacesLauncherUI, Wox.Infrastructure, Wox.Plugin, Wox.Test C:\Program Files\dotnet\sdk\8.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets 171

[PesBandi]

Hi @IamSmeagol
If the CMake dialog appears again, I believe you can just choose Do not enable.
As for the build errors, PowerToys uses .NET 9, which isn't supported by your VS version. You need to update your Visual Studio. You can do so by going into Help > Check for Updates and then Update.
Hope this helps. If you experience any other errors, don't hesitate to contact me

[IamSmeagol]

I have updated my visual studio to 17.13.1
I was able to build and run the tests. A few tests were skipped or failed that were unrelated to the change. What are the next steps to making a pull request?

[PesBandi]

First of all, you should test your changes. You can find the executable at pt_repo_path\x64\Release\Powertoys.exe (assuming you built x64 - Release). If you use PowerToys, you have to first kill the original one, so they don't conflict.

To open a pull request:

1. Head to the Pull requests tab on GitHub
2. Click New pull request
3. At the top, click compare across forks
4. Select microsoft:main as the base and IamSmeagol:patch-1 as compare.
5. Click Create pull request
6. Fill out the template and click Create

[IamSmeagol]

Thank you so much for helping! My pull request was merged, I will close this when it 0.89 is released

[PesBandi]

I'm glad I could help! I hope you'll continue to contribute. Good luck :)