URL encode does not encode '!'

[sirnple]

Microsoft PowerToys version

0.86.0

Installation method

WinGet

Running as admin

No

Area(s) with issue?

PowerToys Run

Steps to reproduce

PowerToys Run: # url https://www.github.com/query=aaa!

✔️ Expected Behavior

Expect result: https%3a%2f%2fwww.github.com%2fquery%3daaa%21

❌ Actual Behavior

Actual result: https%3a%2f%2fwww.github.com%2fquery%3daaa!

Other Software

No response

[htcfreek]

@OldUser101
Your contribution is welcome and thank you for your work on this. Feel free to open a PR. If you have any further questions don't worry to ask them.

[OldUser101]

@htcfreek
Is it worth adding a mode setting for URL encoding? Uri.EscapeDataString fixes this issue, but could introduce issues as it uses a newer standard that categorises some characters differently. For example, the older standard (which we currently use), does not encode the ~ (tilde) characters, but the newer standard will. Spaces are also encoded differently, as %20, rather than a +. A setting would allow the user to select based on preference.

[htcfreek]

@OldUser101
Don't we support both type by using different commands?

# esc:data .... should bring the results you expect.

If not we should add a new command.

[OldUser101]

@htcfreek
Should this issue be closed and marked as intended functionality?
! is technically a valid URL character by RFC 3986, and # esc:data is available if this needs to be encoded.

[htcfreek]

@sirnple
See this as it is the solution for your problem. /helped

[microsoft-github-policy-service]

This issue is now marked as resolved. If you have any follow-up questions, please don't hesitate to ask. You can find out more about PowerToys functionalities in our end-user documentation.