Fixing command duplicates when loading commands from provider

[guimafelipe]

There is a bug in command palette where the top level commands from extensions gets duplicated after the extension raises items changed, or when it is requested by CmdPal for any reason. This didn't happen when we kill CmdPal and open it again.

When investigating, I noticed that the UpdateCommandsForProvider method was not deleting the top level commands for the extension.
This seems to be happening because the comparison var isTheSame = wrapper == firstCommand; is not comparing objects of the same type. It was comparing a TopLevelViewModel with a CommandItem, and it was never set to true.

I change it to compare the TopLevelViewModel of both commands, and now it seems to be detecting correctly.

Another option of fix could be comparing the CommandItems.

[zadjii-msft]

I took this one step further, and I may just merge that into here: 96c390e

you're right, we can just check the CommandItems

[zadjii-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

Pull Request Overview

This PR addresses a bug in the command palette where top-level commands from extensions are duplicated due to inaccurate object comparison.

• Changed the object comparison in the UpdateCommandsForProvider method to compare TopLevelViewModel objects instead of underlying command models.
• Removed outdated comments and unused code paths related to direct access to ICommandItem.

Comments suppressed due to low confidence (1)

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/TopLevelCommandManager.cs:136

• Ensure that both 'wrapper' and 'firstCommand' are of the same type before comparing; if not, consider explicitly comparing their relevant TopLevelViewModel properties to avoid any type mismatch issues.

var isTheSame = wrapper == firstCommand;

[guimafelipe]

Another bug that I found while testing today is that when a user uninstalled or updated an extension, it was still being listed as an enabled extension. This was generating duplicates in the top level commands in case of updating an extension, and resulting in unpredictable behavior and occasional crashes in CmdPal.

Added a fix for that on ExtensionService, removing the uninstalled extensions also from the _enabledExtensions list.

[crutkas]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).