Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CmdPal] Settings UI polishing #38094

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

davidegiacometti
Copy link
Collaborator

@davidegiacometti davidegiacometti commented Mar 22, 2025

Summary of the Pull Request

Settings window UI polishing:

  • Make the navigation view toggle button move in the title bar when navigation view mode is compact or minimal
  • Center settings card in the window
  • Properly set windows icon in order to make it visible in task manager and task view

main branch
image

image

PR
image

image

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@niels9001
Copy link
Contributor

niels9001 commented Mar 22, 2025

@davidegiacometti Would it make sense to use the same logic as we are using in PowerToys Settings? Meaning, having the pane togglebutton in the titlebar?

That's exactly what you did :)! I was just looking at the first screenshot haha

@zadjii-msft zadjii-msft added the Product-Command Palette Refers to the Command Palette utility label Mar 22, 2025
@davidegiacometti
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crutkas
Copy link
Member

crutkas commented Mar 24, 2025

@niels9001 yoyr call for .90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants