Logs are never cleaned up

[enricogior]

PowerToys logs are created and never deleted, we should automatically clean up hold logs.
We need to verify it for each module:

• Color Picker
• FancyZones
• File Explorer add-ons
• Image Resizer
• Keyboard Manager
• PowerRename
• PowerToys Run
• Shortcut Guide
• Settings
• Runner

[davidegiacometti]

What about chose a logging library and use rotation/retention capabilities?

For C# at the moment there are many loggers used:

Settings
https://github.com/microsoft/PowerToys/blob/master/src/core/Microsoft.PowerToys.Settings.UI.Library/Utilities/Logger.cs

ColorPicker
https://github.com/microsoft/PowerToys/blob/master/src/modules/colorPicker/ColorPickerUI/Helpers/Logger.cs

Run
https://github.com/microsoft/PowerToys/blob/master/src/modules/launcher/Wox.Plugin/Logger/Log.cs
https://github.com/microsoft/PowerToys/blob/master/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Logger/ProgramLogger.cs

[enricogior]

@davidegiacometti
we should definitely use the same logger for all C# projects.
Regarding rotation, I'm not a fan of it since we might loose information that we need.
I would prefer a logger that logs by day and we should keep the last x days.

[davidegiacometti]

If we want to use a logging library I can work on this for the C# area but I am not sure to finish for 0.29 release.
Any preference for the library? nlog, log4net?
Would be nice to rely on Microsoft.Extensions.Logging as abstraction even if there is no dependency injection since there are also unit tests.

[davidegiacometti]

@crutkas any thought on logging?

[ivan100sic]

Logs in projects which use spdlog are not erased properly due to a bug in that library. Namely, one function (init_filenames_q_) assumes that logs are always written on consecutive days, which may not be true in case a user doesn't run PowerToys on some day. So perhaps we should try to fix that bug upstream.