Commit 4c1abab
ci(release): RP-5 — add Docker build + push to GHCR; gate GH Release publish
Adds 2 new release.yml jobs on prod tag push:
- build-and-push-docker-cpu (needs publish-pypi-cpu) — pushes
ghcr.io/microsoft/sparrow-engine-server:vX.Y.Z + :sparrow-combined
- build-and-push-docker-gpu (needs publish-pypi-gpu) — pushes
ghcr.io/microsoft/sparrow-engine-server-gpu:vX.Y.Z + :sparrow-combined
Modifies publish-cli-release-assets:
- Adds both docker jobs to needs:
- Adds both to the if: success-check (failure of either now blocks GH Release publish)
Why gate the GH Release publish on docker push success:
The sparrow webapp consumes a pinned engine image. RP-5 wires an auto-PR
on the sparrow repo (Clamps251/sparrow) that polls
microsoft/Pytorch-Wildlife/releases/latest every 30 min. Gating the GH
Release publish on docker push makes 'release published' a strict
happens-after of 'both images on GHCR' — sparrow's poll is race-free.
Tradeoff: docker failure blocks the GH Release page (PyPI wheels still
publish earlier in the chain). Acceptable; failures are rare and fixing
the Dockerfile unblocks both via workflow_dispatch.
Runner: free ubuntu-latest works for the GPU image despite no GPU
present (cudarc fallback-dynamic-loading + nvjpeg-sys pre-generated
bindings skip CUDA Toolkit at build time — RP-19 precedent for the
Windows GPU wheel). Disk: free-disk-space action pre-step on the GPU
job to ensure 6-8GB headroom for the cuDNN base layer.
Cache: separate ghcr.io/microsoft/sparrow-engine-server-buildcache:cpu
(and :gpu) registry caches so runtime image tag lists stay clean (the
sparrow poll workflow filters tags by shape; a 'buildcache' tag would
confuse downstream introspection).
GHCR auth via GITHUB_TOKEN + packages: write — zero secrets to manage.
Image visibility flips to PUBLIC manually after first push (one-time
operator action; documented in RP-5 final_design.md § Test plan Phase 1).
Sparrow-side workflow + baseline_up.sh + pin contract changes land
separately on Clamps251/sparrow @ feat/rp-5-image-pin-auto-pr.
Refs:
- Design: sparrow-engine-dev:docs/design/rp-5-image-pin-auto-pr/final_design.md
- Ledger: rp-5-implement (sparrow-engine-dev session 4f3f88eb)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent b710048 commit 4c1abab
1 file changed
Lines changed: 105 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1162 | 1162 | | |
1163 | 1163 | | |
1164 | 1164 | | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
| 1215 | + | |
| 1216 | + | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
| 1220 | + | |
| 1221 | + | |
| 1222 | + | |
| 1223 | + | |
| 1224 | + | |
| 1225 | + | |
| 1226 | + | |
| 1227 | + | |
| 1228 | + | |
| 1229 | + | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
1165 | 1266 | | |
1166 | 1267 | | |
1167 | 1268 | | |
| |||
1184 | 1285 | | |
1185 | 1286 | | |
1186 | 1287 | | |
| 1288 | + | |
| 1289 | + | |
1187 | 1290 | | |
1188 | 1291 | | |
1189 | 1292 | | |
1190 | 1293 | | |
1191 | 1294 | | |
1192 | 1295 | | |
| 1296 | + | |
| 1297 | + | |
1193 | 1298 | | |
1194 | 1299 | | |
1195 | 1300 | | |
| |||
0 commit comments