Skip to content

Commit ef2faeb

Browse files
zhmiaoCopilot
andcommitted
ci(rp-4): publish-cli-release-assets fires when 3 of 4 CLI builds succeed
Windows build-cli-windows has been the persistent failure across v0.1.6/ v0.1.7/v0.1.8 (3 attempts) — keeps failing at 'Package zip' even with choco install zip + as_posix() on ORT_CAPI + the script's bsdtar fallback. Without reproducible local Windows env to debug, this is becoming the blocker for the brew tap shipping at all. Resolution: loosen publish-cli-release-assets dependency on Windows specifically, while keeping it in 'needs' so we can pick up the .zip automatically when Windows starts succeeding later. - if: condition now checks each needed job's .result individually (Linux CPU + Linux GPU + macOS arm64 must succeed) - fail_on_unmatched_files: false on the action-gh-release step so a missing .zip glob doesn't fail the attach step - build-cli-windows still runs every release; its artifact (when successful) is picked up automatically by the cli-* glob Trade-off: GH Release ships 6 of 8 assets until Windows is fixed. Operators on Windows fall back to the Python wheel or Docker until the .ps1 installer has a tarball to install. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 9e8392e commit ef2faeb

1 file changed

Lines changed: 18 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,19 @@ jobs:
788788

789789
publish-cli-release-assets:
790790
name: Attach CLI tarballs to GitHub Release
791-
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && !contains(github.ref_name, '-')
791+
# Tag-push only; skips on hyphenated tags (RC / pre-release).
792+
# Fires when the 3 reliable CLI builds succeed; build-cli-windows is
793+
# allowed to fail in the meantime (Windows .zip packaging is a known
794+
# follow-up — see RP-4 Windows tracking ticket). When Windows succeeds
795+
# the .zip is attached automatically via the files glob below; when it
796+
# fails, the release ships with 6 of 8 assets (Linux + macOS + GPU
797+
# tarballs and their sha256s).
798+
if: |
799+
github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
800+
&& !contains(github.ref_name, '-')
801+
&& needs.build-cli-linux-cpu.result == 'success'
802+
&& needs.build-cli-linux-gpu.result == 'success'
803+
&& needs.build-cli-macos-arm64.result == 'success'
792804
needs:
793805
- build-cli-linux-cpu
794806
- build-cli-linux-gpu
@@ -824,7 +836,11 @@ jobs:
824836
825837
- uses: softprops/action-gh-release@v2
826838
with:
827-
fail_on_unmatched_files: true
839+
# Soft-fail when Windows tarball is missing — see job-level if
840+
# gate above. When build-cli-windows starts succeeding, the
841+
# glob picks up the .zip automatically; for now the 6 reliable
842+
# assets ship.
843+
fail_on_unmatched_files: false
828844
files: |
829845
dist/sparrow-engine-cpu-*-linux-x86_64.tar.gz
830846
dist/sparrow-engine-cpu-*-linux-x86_64.tar.gz.sha256

0 commit comments

Comments
 (0)