Copilot generated upgrades to add_submodule

Author: jenshnielsen

src/qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1517A.py

@@ -462,6 +462,9 @@ def __init__(
         0.001 to 100 for UHVU
         """
 
+        self.iv_sweep: KeysightB1500IVSweeper = self.add_submodule("iv_sweep", KeysightB1500IVSweeper(self, "iv_sweep"))
+        """Instrument module iv_sweep"""
+
     def _set_sweep_mode(self, value: constants.SweepMode) -> None:
         self._sweep_step_parameters["sweep_mode"] = value
         self._set_from_sweep_step_parameters()
@@ -857,7 +860,9 @@ def __init__(
         # We want to snapshot these configuration dictionaries
         self._meta_attrs += ["_measure_config", "_source_config", "_timing_parameters"]
 
-        self.add_submodule("iv_sweep", KeysightB1500IVSweeper(self, "iv_sweep"))
+        self.iv_sweep: KeysightB1500IVSweeper = self.add_submodule("iv_sweep", KeysightB1500IVSweeper(self, "iv_sweep"))
+        """Instrument module iv_sweep"""
+
         self.setup_fnc_already_run: bool = False
         self.power_line_frequency: int = 50
         self._average_coefficient: int = 1

src/qcodes/instrument_drivers/Keysight/keysightb1500/KeysightB1520A.py

@@ -519,7 +519,8 @@ def __init__(
         )
         """Parameter capacitance"""
 
-        self.add_submodule("correction", KeysightB1500Correction(self, "correction"))
+        self.correction: KeysightB1500Correction = self.add_submodule("correction", KeysightB1500Correction(self, "correction"))
+        """Instrument module correction"""
 
         self.phase_compensation_mode: Parameter = self.add_parameter(
             name="phase_compensation_mode",
@@ -563,7 +564,8 @@ def __init__(
         fluctuations by changing the bias and so on.
         """
 
-        self.add_submodule("cv_sweep", KeysightB1500CVSweeper(self, "cv_sweep"))
+        self.cv_sweep: KeysightB1500CVSweeper = self.add_submodule("cv_sweep", KeysightB1500CVSweeper(self, "cv_sweep"))
+        """Instrument module cv_sweep"""
 
         self.adc_coef: GroupParameter = self.add_parameter(
             name="adc_coef",

src/qcodes/instrument_drivers/Keysight/private/Keysight_344xxA_submodules.py

@@ -983,9 +983,12 @@ def __init__(
         ####################################
         # Submodules
 
-        self.add_submodule("display", Keysight344xxADisplay(self, "display"))
-        self.add_submodule("trigger", Keysight344xxATrigger(self, "trigger"))
-        self.add_submodule("sample", Keysight344xxASample(self, "sample"))
+        self.display: Keysight344xxADisplay = self.add_submodule("display", Keysight344xxADisplay(self, "display"))
+        """Instrument module display"""
+        self.trigger: Keysight344xxATrigger = self.add_submodule("trigger", Keysight344xxATrigger(self, "trigger"))
+        """Instrument module trigger"""
+        self.sample: Keysight344xxASample = self.add_submodule("sample", Keysight344xxASample(self, "sample"))
+        """Instrument module sample"""
 
         ####################################
         # Measurement Parameters

src/qcodes/instrument_drivers/tektronix/DPO7200xx.py

@@ -74,11 +74,16 @@ def __init__(
     ) -> None:
         super().__init__(name, address, **kwargs)
 
-        self.add_submodule("horizontal", TektronixDPOHorizontal(self, "horizontal"))
-
-        self.add_submodule("data", TektronixDPOData(self, "data"))
-
-        self.add_submodule("waveform", TektronixDPOWaveformFormat(self, "waveform"))
+        self.horizontal: TektronixDPOHorizontal = self.add_submodule("horizontal", TektronixDPOHorizontal(self, "horizontal"))
+        """Instrument module horizontal"""
+        self.data: TektronixDPOData = self.add_submodule("data", TektronixDPOData(self, "data"))
+        """Instrument module data"""
+        self.waveform: TektronixDPOWaveformFormat = self.add_submodule("waveform", TektronixDPOWaveformFormat(self, "waveform"))
+        """Instrument module waveform"""
+        self.trigger: TektronixDPOTrigger = self.add_submodule("trigger", TektronixDPOTrigger(self, "trigger"))
+        """Instrument module trigger"""
+        self.delayed_trigger: TektronixDPOTrigger = self.add_submodule("delayed_trigger", TektronixDPOTrigger(self, "delayed_trigger", delayed_trigger=True))
+        """Instrument module delayed_trigger"""
 
         measurement_list = ChannelList(self, "measurement", TektronixDPOMeasurement)
         for measurement_number in range(1, self.number_of_measurements):
@@ -109,13 +114,6 @@ def __init__(
 
         self.add_submodule("channel", channel_list)
 
-        self.add_submodule("trigger", TektronixDPOTrigger(self, "trigger"))
-
-        self.add_submodule(
-            "delayed_trigger",
-            TektronixDPOTrigger(self, "delayed_trigger", delayed_trigger=True),
-        )
-
         self.connect_message()
 
     def ask_raw(self, cmd: str) -> str:

src/qcodes/instrument_drivers/yokogawa/GS200.py

@@ -479,13 +479,14 @@ def __init__(
 
         # Check if monitor is present, and if so enable measurement
         monitor_present = "/MON" in self.ask("*OPT?")
-        measure = GS200_Monitor(self, "measure", monitor_present)
-        self.add_submodule("measure", measure)
+        self.measure: GS200_Monitor = self.add_submodule("measure", GS200_Monitor(self, "measure", monitor_present))
+        """Instrument module measure"""
 
         # Reset function
         self.add_function("reset", call_cmd="*RST")
 
-        self.add_submodule("program", GS200Program(self, "program"))
+        self.program: GS200Program = self.add_submodule("program", GS200Program(self, "program"))
+        """Instrument module program"""
 
         self.BNC_out: Parameter = self.add_parameter(
             "BNC_out",

src/qcodes/instrument_drivers/yokogawa/Yokogawa_GS200.py

@@ -474,13 +474,14 @@ def __init__(
 
         # Check if monitor is present, and if so enable measurement
         monitor_present = "/MON" in self.ask("*OPT?")
-        measure = YokogawaGS200Monitor(self, "measure", monitor_present)
-        self.add_submodule("measure", measure)
+        self.measure: YokogawaGS200Monitor = self.add_submodule("measure", YokogawaGS200Monitor(self, "measure", monitor_present))
+        """Instrument module measure"""
 
         # Reset function
         self.add_function("reset", call_cmd="*RST")
 
-        self.add_submodule("program", YokogawaGS200Program(self, "program"))
+        self.program: YokogawaGS200Program = self.add_submodule("program", YokogawaGS200Program(self, "program"))
+        """Instrument module program"""
 
         self.BNC_out: Parameter = self.add_parameter(
             "BNC_out",