Update resource estimation notebooks to use new features (#772)

* Change error rate for T-state requirements.

* Input arguments for Q# sample.

* Input arguments for Q# sample.

* Fix broken link.

Author: msoeken

README.md

@@ -80,7 +80,7 @@ This repo contains several configuration files that will make it easy to get sta
 
 ### Visual Studio Code
 
-If you prefer to develop code locally, we recommend to install an editor such as [Visual Studio Code](https://code.visualstudio.com/download). Make sure to install the [.NET Core SDK 3.1 or later](https://www.microsoft.com/net/download) on your local machine. For more detailed instructions on how to set up VS Code for development with the QDK, go to our docs [here](https://docs.microsoft.com/azure/quantum/install-command-line-qdk).
+If you prefer to develop code locally, we recommend to install an editor such as [Visual Studio Code](https://code.visualstudio.com/download). Make sure to install the [.NET Core SDK 3.1 or later](https://dotnet.microsoft.com/download) on your local machine. For more detailed instructions on how to set up VS Code for development with the QDK, go to our docs [here](https://docs.microsoft.com/azure/quantum/install-command-line-qdk).
 
 Once you have installed VS Code and the .NET Core SDK, download this repository to your computer and open the folder in VS Code. The editor will automatically recognize the files in the `.vscode` folder and request you to install the recommended extension. This includes the [Microsoft Quantum Development Kit for Visual Studio Code](https://marketplace.visualstudio.com/items?itemName=quantum.quantum-devkit-vscode) extension, which is the fastest way to get started with the QDK.
 

samples/azure-quantum/resource-estimation/advanced-estimation.ipynb

@@ -67,6 +67,15 @@
     "As running example algorithm we are creating a multiplier using the [MultiplyI](https://docs.microsoft.com/qsharp/api/qsharp/microsoft.quantum.arithmetic.multiplyi) operation.  We can configure the size of the multiplier with a bitwidth parameter. The operation will have two input registers with that bitwidth, and one output register with the size of twice the bitwidth."
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "EstimateMultiplication: any = None # Make Python recognize the Q# function (optional)"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -131,13 +140,7 @@
     "We are now submitting resource estimation jobs for all combinations of job\n",
     "parameters and input arguments.\n",
     "\n",
-    "Since the Resource Estimator does not support input parameters for operations,\n",
-    "we are creating a wrapper operation on the fly by inserting the bitwidth\n",
-    "directly into the source code and then compiling it using `qsharp.compile`.\n",
-    "This is a generic method that you can use to generate operations for resource\n",
-    "estimation from Python.\n",
-    "\n",
-    "We then submit this wrapper operation for each experiment configuration using\n",
+    "We submit the multiplication operation for each experiment configuration using\n",
     "`qsharp.azure.submit`.  This will return a job object from which we extract the\n",
     "Job ID. and store it in the `jobs` dictionary.  Note that loop will not wait for\n",
     "jobs to be finished."
@@ -157,13 +160,10 @@
     "display(progress_bar)\n",
     "\n",
     "for bitwidth in bitwidths:\n",
-    "    callable = qsharp.compile(f\"\"\"operation EstimateMultiplication{bitwidth}() : Unit {{ EstimateMultiplication({bitwidth}); }}\"\"\");\n",
-    "    print(callable)\n",
-    "\n",
     "    for name, params in input_params.items():\n",
     "        progress_bar.description = f\"{bitwidth}: {name}\"\n",
     "\n",
-    "        result = qsharp.azure.submit(callable, jobParams=params)\n",
+    "        result = qsharp.azure.submit(EstimateMultiplication, bitwidth=bitwidth, jobParams=params)\n",
     "        jobs[name].append(result.id)\n",
     "        progress_bar.value += 1"
    ]

samples/azure-quantum/resource-estimation/estimation-qir.ipynb

@@ -148,7 +148,7 @@
     "The QIR we submit to the function defined above must be passed in bitcode\n",
     "format.  We obtain this format by calling `bitcode` instead of `ir` on the\n",
     "module.  We can also pass resource estimation specific arguments, e.g., setting\n",
-    "the error rate to 1%."
+    "the error rate to 0.5%."
    ]
   },
   {
@@ -157,7 +157,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "job = resource_estimation_job_from_qir(provider, module.bitcode(), errorBudget=0.01)\n",
+    "job = resource_estimation_job_from_qir(provider, module.bitcode(), errorBudget=0.005)\n",
     "\n",
     "# Alternatively you can generate QIR bitcode using the ir_to_bitcode function from PyQIR, e.g.,\n",
     "#\n",

samples/azure-quantum/resource-estimation/estimation-qsharp.ipynb

@@ -70,6 +70,15 @@
     "As running example algorithm we are creating a multiplier using the [MultiplyI](https://docs.microsoft.com/qsharp/api/qsharp/microsoft.quantum.arithmetic.multiplyi) operation.  We can configure the size of the multiplier with a bitwidth parameter. The operation will have two input registers with that bitwidth, and one output register with the size of twice the bitwidth."
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "EstimateMultiplication: any = None # Make Python recognize the Q# function (optional)"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -100,36 +109,7 @@
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "In order to estimate an operation using the Azure Quantum Resource Estimator target, it cannot take any input arguments and must have a `Unit` return value.  But we can simply create a new instance for a specific bitwidth, for example 8 in this case."
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "EstimateMultiplication8: any = None # Make Python recognize the Q# function (optional)"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "%%qsharp\n",
-    "\n",
-    "operation EstimateMultiplication8() : Unit {\n",
-    "    EstimateMultiplication(8);\n",
-    "}"
-   ]
-  },
-  {
-   "cell_type": "markdown",
-   "metadata": {},
-   "source": [
-    "Let's now estimate the physical resources for this operation using the default assumptions.  We can submit the operation to the resource estimation target using the `qsharp.azure.execute` function."
+    "Let's now estimate the physical resources for this operation using a bitwidth of 8 and the default assumptions.  We can submit the operation to the resource estimation target using the `qsharp.azure.execute` function."
    ]
   },
   {
@@ -138,7 +118,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "result = qsharp.azure.execute(EstimateMultiplication8)"
+    "result = qsharp.azure.execute(EstimateMultiplication, bitwidth=8)"
    ]
   },
   {
@@ -226,7 +206,8 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "result = qsharp.azure.execute(EstimateMultiplication8,\n",
+    "result = qsharp.azure.execute(EstimateMultiplication,\n",
+    "            bitwidth=8,\n",
     "            jobParams={\n",
     "                \"qubitParams\": {\n",
     "                    \"name\": \"qubit_maj_ns_e6\"\n",
@@ -477,7 +458,8 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "result_maj_floquet = qsharp.azure.execute(EstimateMultiplication8,\n",
+    "result_maj_floquet = qsharp.azure.execute(EstimateMultiplication,\n",
+    "            bitwidth=8,\n",
     "            jobParams={\n",
     "                \"qubitParams\": {\n",
     "                    \"name\": \"qubit_maj_ns_e6\"\n",
@@ -567,7 +549,8 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "result_maj_floquet_e1 = qsharp.azure.execute(EstimateMultiplication8,\n",
+    "result_maj_floquet_e1 = qsharp.azure.execute(EstimateMultiplication,\n",
+    "            bitwidth=8,\n",
     "            jobParams={\n",
     "                \"qubitParams\": {\n",
     "                    \"name\": \"qubit_maj_ns_e6\"\n",