Add diff chunk header lines to Git

[michaelblyons]

Search Terms

userdiff xfuncname

Suggestion

Please add regular expressions to https://github.com/git/git/blob/master/userdiff.c such that TypeScript constructs can be identified in a predictable manner by the Git diff algorithm.

Use Cases

When I do a git diff or git add -p that includes TypeScript code, it's nice to see the function and/or class names of the changed lines I am looking at.

Examples

• git diff -- *.ts
• git add -p -- *.ts

Checklist

My suggestion meets these guidelines:

• This wouldn't be a breaking change in existing TypeScript/JavaScript code
• This wouldn't change the runtime behavior of existing JavaScript code
• This could be implemented without emitting different JS based on the types of the expressions
• This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
• This feature would agree with the rest of TypeScript's Design Goals.
  • Particularly "Provide a structuring mechanism for larger pieces of code."

[eloisepeng]

This seem to be a git related issue/feature to add. We can't do much on the Typescript side.

[michaelblyons]

You can clone https://github.com/git/git and submit a patch to their mailing list. You can even do use GitGitGadget to convert a PR to the right format.

[michaelblyons]

@yehee's PR seems to have stalled (git/git#859). Does anyone else want to take it up?

[matthewhughes934]

@yehee's PR seems to have stalled (git/git#859). Does anyone else want to take it up?

I've opened git/git#1746, though I'm not an advanced typescript developer so feedback is very welcome