Skip to content

Commit e919005

Browse files
benhillisBen HillisCopilot
authored
Disable SDL codesign auto-scan on the package job (#40657)
The Guardian CodeSign post-analysis scans the entire source checkout and flags every in-repo .ps1 as unsigned (17 errors, breaking the release build). Two prior attempts to filter the findings via the documented ob_sdl_codeSignValidation_excludes variable - at pipeline-level (b011cf7) and at the package job's variables block (PR #40653) - were both silently ignored. Disable the auto-scan on the package job; the msixbundle and nupkg outputs are explicitly signed AND verified by the EsrpCodeSigning tasks in the same job (SigntoolVerify / NuGetVerify operations), so signing coverage on the actual release artifacts is preserved. The build_x64 / build_arm64 jobs keep codesign validation enabled. Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent f67086e commit e919005

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.pipelines/package-stage.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ stages:
4545
ob_outputDirectory: '$(Build.SourcesDirectory)\out'
4646
ob_artifactBaseName: 'drop_wsl'
4747
ob_artifactSuffix: '_package'
48-
ob_sdl_codeSignValidation_excludes: -|**\*.ps1
48+
# Outputs are explicitly signed+verified by the EsrpCodeSigning tasks below.
49+
ob_sdl_codeSignValidation_enabled: false
4950
buildStagePackageVersion: $[ stageDependencies.build_x64.build_x64.outputs['version.WSL_PACKAGE_VERSION'] ]
5051
buildStageNugetVersion: $[ stageDependencies.build_x64.build_x64.outputs['version.WSL_NUGET_PACKAGE_VERSION'] ]
5152

0 commit comments

Comments
 (0)