Skip to content

Commit 57a6249

Browse files
Centralize app version info in project file for maintainability (#2055)
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR centralizes the app version management by introducing a `Version` property in the app project file. ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Currently, we are manually updating these files to bump the app version, which is error-prone and easy to miss. - Package.appxmanifest - Package.Dev.appxmanifest - AssemblyInfo.cs Closes #2054. ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Ran the app and confirmed the changes. ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change)
1 parent 88c91e9 commit 57a6249

File tree

4 files changed

+698
-719
lines changed

4 files changed

+698
-719
lines changed

WinUIGallery/Package.Dev.appxmanifest

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<Package
3-
xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10"
4-
xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest"
5-
xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10"
6-
xmlns:uap3="http://schemas.microsoft.com/appx/manifest/uap/windows10/3"
7-
xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities"
8-
IgnorableNamespaces="uap mp uap3">
2+
<Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" xmlns:uap3="http://schemas.microsoft.com/appx/manifest/uap/windows10/3" xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" IgnorableNamespaces="uap mp uap3">
93
<!--Note: package version and assembly version must be kept in sync-->
104
<Identity Name="Microsoft.WinUI3ControlsGallery.Debug" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" Version="2.7.0.0" />
115
<mp:PhoneIdentity PhoneProductId="863667e0-667a-4bb4-ac52-c59656c7333a" PhonePublisherId="00000000-0000-0000-0000-000000000000" />
@@ -16,7 +10,7 @@
1610
<uap:SupportedUsers>multiple</uap:SupportedUsers>
1711
</Properties>
1812
<Dependencies>
19-
<TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.19041.0" />
13+
<TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.19041.0" />
2014
</Dependencies>
2115
<Resources>
2216
<Resource Language="x-generate" />

WinUIGallery/Package.appxmanifest

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<Package
3-
xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10"
4-
xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest"
5-
xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10"
6-
xmlns:uap3="http://schemas.microsoft.com/appx/manifest/uap/windows10/3"
7-
xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities"
8-
IgnorableNamespaces="uap mp uap3">
2+
<Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" xmlns:uap3="http://schemas.microsoft.com/appx/manifest/uap/windows10/3" xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" IgnorableNamespaces="uap mp uap3">
93
<!--Note: package version and assembly version must be kept in sync-->
104
<Identity Name="Microsoft.WinUI3ControlsGallery" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" Version="2.7.0.0" />
115
<mp:PhoneIdentity PhoneProductId="863667e0-667a-4bb4-ac52-c59656c7333a" PhonePublisherId="00000000-0000-0000-0000-000000000000" />
@@ -16,7 +10,7 @@
1610
<uap:SupportedUsers>multiple</uap:SupportedUsers>
1711
</Properties>
1812
<Dependencies>
19-
<TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.19041.0" />
13+
<TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.17763.0" MaxVersionTested="10.0.19041.0" />
2014
</Dependencies>
2115
<Resources>
2216
<Resource Language="x-generate" />
@@ -31,7 +25,7 @@
3125
<uap:ShowOn Tile="square310x310Logo" />
3226
</uap:ShowNameOnTiles>
3327
</uap:DefaultTile>
34-
<uap:SplashScreen Image="Assets\Tiles\SplashScreen.png"/>
28+
<uap:SplashScreen Image="Assets\Tiles\SplashScreen.png" />
3529
</uap:VisualElements>
3630
<Extensions>
3731
<uap3:Extension Category="windows.appUriHandler">

WinUIGallery/Properties/AssemblyInfo.cs

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)