fix: centralize hardcoded ring thresholds and constants (#188)

* fix: centralize hardcoded ring thresholds and constants into constants.py

Fixes #171

Ring thresholds and constants were hardcoded with duplicate values across
multiple files (rate_limiter.py, enforcer.py, models.py, vouching.py,
orchestrator.py). This commit introduces a single constants.py module
under hypervisor/ and updates all source files to import from it.

Constants centralized:
- Ring trust-score thresholds (0.95, 0.70, 0.60)
- Rate-limiter defaults per ring (req/s and burst capacity)
- Vouching/sponsorship thresholds (score scale, bond pct, max exposure)
- Saga orchestrator defaults (retries, delay, step timeout)
- Validation limits (agent ID, name, API path, participants, duration)
- Risk-weight ranges by reversibility level
- Session default min_eff_score

All 562 existing tests pass with zero failures.

* fix: resolve F401 lint errors in agent-compliance package

* fix: resolve lint errors in agent-mesh package (W293, F401, F821, E402)

* fix: resolve lint errors in agent-sre package (F401, E741)

* fix: resolve lint errors in agent-os package (F401, F541, noqa directives)

* fix: skip gRPC transport tests when grpcio is not installed

Author: Ricky-G

packages/agent-compliance/src/agent_compliance/__init__.py

@@ -17,11 +17,11 @@
 
 # Re-export core components for convenience
 try:
-    from agent_os import StatelessKernel, ExecutionContext
+    from agent_os import StatelessKernel, ExecutionContext  # noqa: F401
 except ImportError:
     pass
 
 try:
-    from agentmesh import TrustManager
+    from agentmesh import TrustManager  # noqa: F401
 except ImportError:
     pass

packages/agent-compliance/src/agent_compliance/integrity.py

@@ -28,7 +28,6 @@
 import os
 from dataclasses import dataclass, field
 from datetime import datetime, timezone
-from pathlib import Path
 from typing import Optional
 
 logger = logging.getLogger(__name__)

packages/agent-hypervisor/src/hypervisor/__init__.py

@@ -18,6 +18,9 @@
 
 __version__ = "2.0.2"
 
+# Centralized constants
+from hypervisor import constants  # noqa: F401
+
 # Core models
 from hypervisor.audit.commitment import CommitmentEngine
 

packages/agent-hypervisor/src/hypervisor/constants.py

@@ -0,0 +1,106 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+"""Centralized constants for the Agent Hypervisor package.
+
+All thresholds, limits, and magic numbers used across modules are defined
+here so they can be maintained in a single place.  Modules should import
+from ``hypervisor.constants`` rather than hard-coding values locally.
+"""
+
+from __future__ import annotations
+
+# ---------------------------------------------------------------------------
+# Ring trust-score thresholds
+# ---------------------------------------------------------------------------
+RING_1_TRUST_THRESHOLD: float = 0.95
+"""Minimum effective score (with consensus) for Ring 1 (Privileged)."""
+
+RING_2_TRUST_THRESHOLD: float = 0.60
+"""Minimum effective score for Ring 2 (Standard)."""
+
+RING_1_ENFORCER_THRESHOLD: float = 0.70
+"""Trust threshold used by the RingEnforcer for Ring 1 access."""
+
+# ---------------------------------------------------------------------------
+# Rate-limiter defaults  (requests/sec, burst capacity)
+# ---------------------------------------------------------------------------
+RATE_LIMIT_RING_0: tuple[float, float] = (100.0, 200.0)
+"""Ring 0 (Root/SRE): generous rate limit."""
+
+RATE_LIMIT_RING_1: tuple[float, float] = (50.0, 100.0)
+"""Ring 1 (Privileged): moderate rate limit."""
+
+RATE_LIMIT_RING_2: tuple[float, float] = (20.0, 40.0)
+"""Ring 2 (Standard): conservative rate limit."""
+
+RATE_LIMIT_RING_3: tuple[float, float] = (5.0, 10.0)
+"""Ring 3 (Sandbox): strict rate limit."""
+
+RATE_LIMIT_FALLBACK: tuple[float, float] = RATE_LIMIT_RING_2
+"""Fallback rate limit when a ring is not found in the limits map."""
+
+# ---------------------------------------------------------------------------
+# Vouching / sponsorship thresholds
+# ---------------------------------------------------------------------------
+VOUCHING_SCORE_SCALE: float = 1000.0
+"""Maximum trust-score scale used by the vouching engine."""
+
+VOUCHING_MIN_VOUCHER_SCORE: float = 0.50
+"""Minimum score required to sponsor another agent."""
+
+VOUCHING_DEFAULT_BOND_PCT: float = 0.20
+"""Default percentage of sigma bonded when sponsoring."""
+
+VOUCHING_DEFAULT_MAX_EXPOSURE: float = 0.80
+"""Maximum exposure percentage for bonding."""
+
+# ---------------------------------------------------------------------------
+# Saga orchestrator defaults
+# ---------------------------------------------------------------------------
+SAGA_DEFAULT_MAX_RETRIES: int = 2
+"""Default maximum retries per saga step."""
+
+SAGA_DEFAULT_RETRY_DELAY_SECONDS: float = 1.0
+"""Default delay between saga step retries (multiplied by attempt number)."""
+
+SAGA_DEFAULT_STEP_TIMEOUT_SECONDS: int = 300
+"""Default timeout for a single saga step (5 minutes)."""
+
+# ---------------------------------------------------------------------------
+# Validation limits (models.py)
+# ---------------------------------------------------------------------------
+MAX_AGENT_ID_LENGTH: int = 256
+"""Maximum length of an agent identifier string."""
+
+MAX_NAME_LENGTH: int = 256
+"""Maximum length of resource names."""
+
+MAX_API_PATH_LENGTH: int = 2048
+"""Maximum length of an API path."""
+
+MAX_PARTICIPANTS_LIMIT: int = 1000
+"""Maximum number of participants in a session."""
+
+MAX_DURATION_LIMIT: int = 604_800
+"""Maximum session duration in seconds (7 days)."""
+
+MAX_UNDO_WINDOW: int = 86_400
+"""Maximum undo window in seconds (24 hours)."""
+
+# ---------------------------------------------------------------------------
+# SessionConfig defaults
+# ---------------------------------------------------------------------------
+SESSION_DEFAULT_MIN_EFF_SCORE: float = 0.60
+"""Default minimum effective score for session participation."""
+
+# ---------------------------------------------------------------------------
+# Risk-weight ranges by ReversibilityLevel
+# ---------------------------------------------------------------------------
+RISK_WEIGHT_FULL: tuple[float, float] = (0.1, 0.3)
+"""Risk weight range for fully reversible actions."""
+
+RISK_WEIGHT_PARTIAL: tuple[float, float] = (0.5, 0.8)
+"""Risk weight range for partially reversible actions."""
+
+RISK_WEIGHT_NONE: tuple[float, float] = (0.9, 1.0)
+"""Risk weight range for non-reversible actions."""

packages/agent-hypervisor/src/hypervisor/liability/vouching.py

@@ -13,6 +13,13 @@
 from dataclasses import dataclass, field
 from datetime import UTC, datetime
 
+from hypervisor.constants import (
+    VOUCHING_DEFAULT_BOND_PCT,
+    VOUCHING_DEFAULT_MAX_EXPOSURE,
+    VOUCHING_MIN_VOUCHER_SCORE,
+    VOUCHING_SCORE_SCALE,
+)
+
 
 @dataclass
 class VouchRecord:
@@ -41,10 +48,10 @@ class VouchingEngine:
     Sponsorship stub (community edition: approves all, no bonding).
     """
 
-    SCORE_SCALE = 1000.0
-    MIN_VOUCHER_SCORE = 0.50
-    DEFAULT_BOND_PCT = 0.20
-    DEFAULT_MAX_EXPOSURE = 0.80
+    SCORE_SCALE = VOUCHING_SCORE_SCALE
+    MIN_VOUCHER_SCORE = VOUCHING_MIN_VOUCHER_SCORE
+    DEFAULT_BOND_PCT = VOUCHING_DEFAULT_BOND_PCT
+    DEFAULT_MAX_EXPOSURE = VOUCHING_DEFAULT_MAX_EXPOSURE
 
     def __init__(self, max_exposure: float | None = None) -> None:
         self._vouches: dict[str, VouchRecord] = {}

packages/agent-hypervisor/src/hypervisor/models.py

@@ -9,17 +9,31 @@
 from datetime import UTC, datetime
 from enum import Enum
 
+from hypervisor.constants import (
+    MAX_AGENT_ID_LENGTH,
+    MAX_API_PATH_LENGTH,
+    MAX_DURATION_LIMIT,
+    MAX_NAME_LENGTH,
+    MAX_PARTICIPANTS_LIMIT,
+    MAX_UNDO_WINDOW,
+    RING_1_TRUST_THRESHOLD,
+    RING_2_TRUST_THRESHOLD,
+    RISK_WEIGHT_FULL,
+    RISK_WEIGHT_NONE,
+    RISK_WEIGHT_PARTIAL,
+    SESSION_DEFAULT_MIN_EFF_SCORE,
+)
+
 # Agent ID: DID format (did:method:id) or simple alphanumeric identifiers.
 # Restrict to safe characters — no @, no consecutive special chars.
 _AGENT_ID_PATTERN = re.compile(r"^[a-zA-Z0-9](?:[a-zA-Z0-9._:-]*[a-zA-Z0-9])?$")
-# Max lengths
-_MAX_AGENT_ID_LENGTH = 256
-_MAX_NAME_LENGTH = 256
-_MAX_API_PATH_LENGTH = 2048
-# Session config limits
-_MAX_PARTICIPANTS_LIMIT = 1000
-_MAX_DURATION_LIMIT = 604_800  # 7 days in seconds
-_MAX_UNDO_WINDOW = 86_400  # 24 hours in seconds
+# Aliases for backward compatibility
+_MAX_AGENT_ID_LENGTH = MAX_AGENT_ID_LENGTH
+_MAX_NAME_LENGTH = MAX_NAME_LENGTH
+_MAX_API_PATH_LENGTH = MAX_API_PATH_LENGTH
+_MAX_PARTICIPANTS_LIMIT = MAX_PARTICIPANTS_LIMIT
+_MAX_DURATION_LIMIT = MAX_DURATION_LIMIT
+_MAX_UNDO_WINDOW = MAX_UNDO_WINDOW
 
 
 class ConsistencyMode(str, Enum):
@@ -47,9 +61,9 @@ class ExecutionRing(int, Enum):
     @classmethod
     def from_eff_score(cls, eff_score: float, has_consensus: bool = False) -> ExecutionRing:
         """Derive ring level from effective reputation score."""
-        if eff_score > 0.95 and has_consensus:
+        if eff_score > RING_1_TRUST_THRESHOLD and has_consensus:
             return cls.RING_1_PRIVILEGED
-        elif eff_score > 0.60:
+        elif eff_score > RING_2_TRUST_THRESHOLD:
             return cls.RING_2_STANDARD
         else:
             return cls.RING_3_SANDBOX
@@ -66,11 +80,11 @@ class ReversibilityLevel(str, Enum):
     def risk_weight_range(self) -> tuple[float, float]:
         """Return the (min, max) risk weight ω for this reversibility level."""
         if self == ReversibilityLevel.FULL:
-            return (0.1, 0.3)
+            return RISK_WEIGHT_FULL
         elif self == ReversibilityLevel.PARTIAL:
-            return (0.5, 0.8)
+            return RISK_WEIGHT_PARTIAL
         else:
-            return (0.9, 1.0)
+            return RISK_WEIGHT_NONE
 
     @property
     def default_risk_weight(self) -> float:
@@ -102,7 +116,7 @@ def _validate_identifier(value: str, field_name: str) -> None:
     if not _AGENT_ID_PATTERN.match(value):
         raise ValueError(
             f"{field_name} contains invalid characters: {value!r}. "
-            f"Only alphanumeric, hyphens, underscores, colons, dots, and @ are allowed."
+            f"Only alphanumeric, hyphens, underscores, colons, and dots are allowed."
         )
 
 
@@ -125,7 +139,7 @@ class SessionConfig:
     consistency_mode: ConsistencyMode = ConsistencyMode.EVENTUAL
     max_participants: int = 10
     max_duration_seconds: int = 3600
-    min_eff_score: float = 0.60
+    min_eff_score: float = SESSION_DEFAULT_MIN_EFF_SCORE
     enable_audit: bool = True
     enable_blockchain_commitment: bool = False
 

packages/agent-hypervisor/src/hypervisor/rings/enforcer.py

@@ -12,6 +12,7 @@
 
 from dataclasses import dataclass
 
+from hypervisor.constants import RING_1_ENFORCER_THRESHOLD
 from hypervisor.models import ActionDescriptor, ExecutionRing
 
 
@@ -38,7 +39,7 @@ class RingEnforcer:
     Ring 3 (Sandbox): Read-only / research.
     """
 
-    RING_1_THRESHOLD = 0.70
+    RING_1_THRESHOLD = RING_1_ENFORCER_THRESHOLD
 
     def __init__(self) -> None:
         pass

packages/agent-hypervisor/src/hypervisor/saga/orchestrator.py

@@ -14,6 +14,11 @@
 from collections.abc import Callable
 from typing import Any
 
+from hypervisor.constants import (
+    SAGA_DEFAULT_MAX_RETRIES,
+    SAGA_DEFAULT_RETRY_DELAY_SECONDS,
+    SAGA_DEFAULT_STEP_TIMEOUT_SECONDS,
+)
 from hypervisor.saga.state_machine import (
     Saga,
     SagaState,
@@ -37,8 +42,8 @@ class SagaOrchestrator:
     Joint Liability penalty is triggered.
     """
 
-    DEFAULT_MAX_RETRIES = 2
-    DEFAULT_RETRY_DELAY_SECONDS = 1.0
+    DEFAULT_MAX_RETRIES = SAGA_DEFAULT_MAX_RETRIES
+    DEFAULT_RETRY_DELAY_SECONDS = SAGA_DEFAULT_RETRY_DELAY_SECONDS
 
     def __init__(self) -> None:
         self._sagas: dict[str, Saga] = {}
@@ -59,7 +64,7 @@ def add_step(
         agent_did: str,
         execute_api: str,
         undo_api: str | None = None,
-        timeout_seconds: int = 300,
+        timeout_seconds: int = SAGA_DEFAULT_STEP_TIMEOUT_SECONDS,
         max_retries: int = 0,
     ) -> SagaStep:
         """Add a step to a saga."""

packages/agent-hypervisor/src/hypervisor/security/rate_limiter.py

@@ -12,6 +12,13 @@
 from dataclasses import dataclass, field
 from datetime import UTC, datetime
 
+from hypervisor.constants import (
+    RATE_LIMIT_FALLBACK,
+    RATE_LIMIT_RING_0,
+    RATE_LIMIT_RING_1,
+    RATE_LIMIT_RING_2,
+    RATE_LIMIT_RING_3,
+)
 from hypervisor.models import ExecutionRing
 
 
@@ -51,10 +58,10 @@ def available(self) -> float:
 
 # Default rate limits per ring (requests per second, burst capacity)
 DEFAULT_RING_LIMITS: dict[ExecutionRing, tuple[float, float]] = {
-    ExecutionRing.RING_0_ROOT: (100.0, 200.0),      # SRE: generous
-    ExecutionRing.RING_1_PRIVILEGED: (50.0, 100.0),  # Privileged: moderate
-    ExecutionRing.RING_2_STANDARD: (20.0, 40.0),     # Standard: conservative
-    ExecutionRing.RING_3_SANDBOX: (5.0, 10.0),       # Sandbox: strict
+    ExecutionRing.RING_0_ROOT: RATE_LIMIT_RING_0,
+    ExecutionRing.RING_1_PRIVILEGED: RATE_LIMIT_RING_1,
+    ExecutionRing.RING_2_STANDARD: RATE_LIMIT_RING_2,
+    ExecutionRing.RING_3_SANDBOX: RATE_LIMIT_RING_3,
 }
 
 
@@ -139,7 +146,7 @@ def update_ring(
         """Update an agent's rate limit when their ring changes."""
         key = f"{agent_did}:{session_id}"
         rate, capacity = self._limits.get(
-            new_ring, (20.0, 40.0)
+            new_ring, RATE_LIMIT_FALLBACK
         )
         self._buckets[key] = TokenBucket(
             capacity=capacity,
@@ -164,7 +171,7 @@ def _get_or_create_bucket(
         self, key: str, ring: ExecutionRing
     ) -> TokenBucket:
         if key not in self._buckets:
-            rate, capacity = self._limits.get(ring, (20.0, 40.0))
+            rate, capacity = self._limits.get(ring, RATE_LIMIT_FALLBACK)
             self._buckets[key] = TokenBucket(
                 capacity=capacity,
                 tokens=capacity,

packages/agent-hypervisor/tests/unit/test_config_validation.py

@@ -96,9 +96,9 @@ def test_agent_did_valid_formats(self):
         # DID format
         p1 = SessionParticipant(agent_did="did:mesh:agent-1")
         assert p1.agent_did == "did:mesh:agent-1"
-        # Email-like format
-        p2 = SessionParticipant(agent_did="agent@example.com")
-        assert p2.agent_did == "agent@example.com"
+        # Dotted format
+        p2 = SessionParticipant(agent_did="agent.example.com")
+        assert p2.agent_did == "agent.example.com"
         # Simple alphanumeric
         p3 = SessionParticipant(agent_did="agent_123")
         assert p3.agent_did == "agent_123"