fix(agent-sandbox): warn on hardened image fallback#2910
Open
carloshvp wants to merge 1 commit into
Open
Conversation
Signed-off-by: Carlos Hernandez <carloshvp@gmail.com>
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python:3.11-slimrequire_hardened_image=Trueimage=Root cause
The default image-selection path preserves compatibility by using
python:3.11-slimwhen the hardened image is unavailable. Before this change, that reduction in command restrictions was silent, so operators could miss that the sandbox was running with weaker image-level enforcement.Impact
Existing fallback behavior remains unchanged. Operators now receive an actionable warning when it occurs:
Explicit custom images do not produce this warning.
Refs #2662
Follow-up to #2909
Validation
PYTHONPATH=src:../agent-os/src python3 -m pytest tests -qruff check src/agent_sandbox/docker_provider/provider.pyruff check tests/test_docker_sandbox.py --ignore I001,F401python3 -m compileall -q src/agent_sandboxgit diff --checkAI Assistance
Codex assisted with implementation and test drafting; all output was reviewed and validated.
IP, Patents, and Licensing