fix: address PR review comments (#55)

- Always emit dry-run JSON even when files array is empty
- Normalize all dry-run paths to repo-relative (consistent across --repo)
- Surface nested generation warnings in dry-run mode
- Guard config write-back against non-object JSON (arrays, primitives)
- Add single-root runtime guard to batch instructions command

Author: Harald Kirschner

src/commands/instructions.ts

@@ -117,6 +117,9 @@ export async function instructionsCommand(options: InstructionsOptions): Promise
                 }))
               );
             }
+            for (const warning of nestedResult.warnings) {
+              if (shouldLog(options)) progress.update(`Warning: ${warning}`);
+            }
           } else {
             const actions = await writeNestedInstructions(repoPath, nestedResult, options.force);
             for (const action of actions) {
@@ -170,10 +173,11 @@ export async function instructionsCommand(options: InstructionsOptions): Promise
 
         if (content) {
           if (options.dryRun) {
-            const relPath = path.relative(process.cwd(), outputPath);
+            const relPath = path.relative(repoPath, outputPath);
+            const displayPath = path.relative(process.cwd(), outputPath);
             const byteCount = Buffer.byteLength(content, "utf8");
             if (shouldLog(options)) {
-              progress.update(`[dry-run] Would write ${relPath} (${byteCount} bytes)`);
+              progress.update(`[dry-run] Would write ${displayPath} (${byteCount} bytes)`);
             }
             if (options.json) {
               dryRunFiles.push({ path: relPath, bytes: byteCount });
@@ -348,7 +352,7 @@ export async function instructionsCommand(options: InstructionsOptions): Promise
               }
               if (options.json) {
                 dryRunFiles.push({
-                  path: path.relative(process.cwd(), areaInstructionPath(repoPath, area)),
+                  path: path.relative(repoPath, areaInstructionPath(repoPath, area)),
                   bytes: Buffer.byteLength(body, "utf8")
                 });
               }
@@ -383,7 +387,7 @@ export async function instructionsCommand(options: InstructionsOptions): Promise
       }
     }
 
-    if (options.dryRun && options.json && dryRunFiles.length > 0) {
+    if (options.dryRun && options.json) {
       outputResult(
         { ok: true, status: "noop" as const, data: { dryRun: true, files: dryRunFiles } },
         true

vscode-extension/src/commands/batch.ts

@@ -9,6 +9,12 @@ export async function batchInstructionsCommand(): Promise<void> {
     vscode.window.showWarningMessage("AgentRC: No workspace folders open.");
     return;
   }
+  if (folders.length === 1) {
+    vscode.window.showInformationMessage(
+      "AgentRC: Only one workspace root — use 'Generate Instructions' instead."
+    );
+    return;
+  }
 
   const model = vscode.workspace.getConfiguration("agentrc").get<string>("model");
 

vscode-extension/src/commands/instructions.ts

@@ -101,7 +101,10 @@ export async function instructionsCommand(): Promise<void> {
     let existing: Record<string, unknown> = {};
     try {
       const raw = await fs.promises.readFile(configPath, "utf-8");
-      existing = JSON.parse(raw);
+      const parsed: unknown = JSON.parse(raw);
+      if (parsed && typeof parsed === "object" && !Array.isArray(parsed)) {
+        existing = parsed as Record<string, unknown>;
+      }
     } catch (err: unknown) {
       if ((err as NodeJS.ErrnoException).code !== "ENOENT") {
         throw err; // Malformed JSON — bubble to outer non-fatal catch