Skip to content

Commit f91c398

Browse files
authored
Merge pull request #231 from microsoft/nmetulev/wcr-fixes
fixes in wcrmodeldownloader, apipage, and textrecognition
2 parents 4892f01 + 62ac215 commit f91c398

File tree

3 files changed

+23
-5
lines changed

3 files changed

+23
-5
lines changed

AIDevGallery/Pages/APIs/APIPage.xaml.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ internal sealed partial class APIPage : Page
2121
{
2222
public ModelFamily? ModelFamily { get; set; }
2323
private ModelType? modelFamilyType;
24+
private ModelDetails? modelDetails;
2425

2526
public APIPage()
2627
{
@@ -38,6 +39,7 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
3839
{
3940
modelFamilyType = modelType;
4041
ModelFamily = modelFamilyDetails;
42+
ModelTypeHelpers.ModelDetails.TryGetValue(modelType, out modelDetails);
4143
}
4244
else if (e.Parameter is ModelDetails details)
4345
{
@@ -48,11 +50,13 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
4850
ReadmeUrl = details.ReadmeUrl ?? string.Empty,
4951
Name = details.Name
5052
};
53+
modelDetails = details;
5154
}
5255
else if (e.Parameter is ModelType apiType && ModelTypeHelpers.ApiDefinitionDetails.TryGetValue(apiType, out var apiDefinition))
5356
{
5457
// API
5558
modelFamilyType = apiType;
59+
modelDetails = ModelDetailsHelper.GetModelDetailsFromApiDefinition(apiType, apiDefinition);
5660

5761
ModelFamily = new ModelFamily
5862
{
@@ -67,7 +71,7 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
6771
var sample = SampleDetails.Samples.FirstOrDefault(s => s.Id == apiDefinition.SampleIdToShowInDocs);
6872
if (sample != null)
6973
{
70-
_ = sampleContainer.LoadSampleAsync(sample, [ModelDetailsHelper.GetModelDetailsFromApiDefinition(apiType, apiDefinition)]);
74+
_ = sampleContainer.LoadSampleAsync(sample, [modelDetails]);
7175
}
7276
}
7377
else
@@ -163,7 +167,7 @@ private void SampleList_ItemInvoked(ItemsView sender, ItemsViewItemInvokedEventA
163167
{
164168
if (args.InvokedItem is Sample sample)
165169
{
166-
App.MainWindow.Navigate("Samples", new SampleNavigationArgs(sample));
170+
App.MainWindow.Navigate("Samples", new SampleNavigationArgs(sample, modelDetails));
167171
}
168172
}
169173

AIDevGallery/Samples/SharedCode/WcrApis/WcrModelDownloader.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
88
mc:Ignorable="d">
99

10-
<Grid>
10+
<Grid Background="{ThemeResource SolidBackgroundFillColorBaseBrush}" CornerRadius="4">
1111
<Grid.RowDefinitions>
1212
<RowDefinition Height="*" />
1313
<RowDefinition Height="Auto" />

AIDevGallery/Samples/WCRAPIs/TextRecognition.xaml.cs

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,29 @@ protected override async Task LoadModelAsync(SampleNavigationParameters samplePa
5656
_ = WcrModelDownloader.SetDownloadOperation(ModelType.TextRecognitionOCR, sampleParams.SampleId, TextRecognizer.MakeAvailableAsync); // <exclude-line>
5757
}
5858

59-
await SetImage(System.IO.Path.Join(Windows.ApplicationModel.Package.Current.InstalledLocation.Path, "Assets", "OCR.png"));
59+
// <exclude>
60+
else
61+
{
62+
await SetImage(System.IO.Path.Join(Windows.ApplicationModel.Package.Current.InstalledLocation.Path, "Assets", "OCR.png"));
63+
}
64+
65+
// </exclude>
6066
sampleParams.NotifyCompletion();
6167
}
6268

6369
private async void WcrModelDownloader_DownloadClicked(object sender, EventArgs e)
6470
{
6571
var operation = TextRecognizer.MakeAvailableAsync();
6672

67-
await WcrModelDownloader.SetDownloadOperation(operation);
73+
var success = await WcrModelDownloader.SetDownloadOperation(operation);
74+
75+
// <exclude>
76+
if (success)
77+
{
78+
await SetImage(System.IO.Path.Join(Windows.ApplicationModel.Package.Current.InstalledLocation.Path, "Assets", "OCR.png"));
79+
}
80+
81+
// </exclude>
6882
}
6983

7084
private async void LoadImage_Click(object sender, RoutedEventArgs e)

0 commit comments

Comments
 (0)