fix(install): keep copilot in multi-target --target lists (#1749)

* fix(install): keep copilot in multi-target --target lists

parse_target_field resolves multi-token input through TARGET_ALIASES
(copilot -> vscode), but _resolve_targets_by_scope filtered flag tokens
against CANONICAL_TARGETS, which has copilot and not vscode -- so the
token was silently dropped and only the other targets installed.
Normalize runtime aliases (vscode/agents/intellij -> copilot) through
the shared RUNTIME_TO_CANONICAL_TARGET table before the canonical
filter, mirroring the mcp_integrator precedent.

Closes #1746

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test: clarify alias-vs-canonical contract in #1746 regression trap

Copilot review: docstring said the parse result keeps copilot while the
assertion checks for the vscode alias. Split the two layers explicitly:
parse returns the runtime alias, the targets phase normalizes it back.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore: fold review followups for target aliases

Document the first-seen ordering contract on the runtime target alias helper and credit the community PR in the changelog. These fold the apm-review-panel followups without changing install behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: danielmeppiel <danielmeppiel@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- `apm install --target` with a comma-separated list containing `copilot` (or the `vscode`/`agents` aliases) no longer silently drops the Copilot target. (by @Addono, closes #1746, #1749)
 - `apm install` now resolves relative `path:` deps declared by remote monorepo packages when they stay inside the same remote repo, while still rejecting absolute, escaping, or cross-repo paths; closes #1571. (#1732)
 - Optional-auth MCP registry servers now install without token prompts when values are unset; `apm install` also omits empty runtime config entries and preserves user-edited optional values on reinstall; refs #20. (#1734)
 - Dependencies with the same path on different git hosts no longer collide in `apm.lock.yaml`; `apm install` keeps GitHub/GitLab PATs off generic-host file downloads, routes bespoke GitLab hosts through `type: gitlab`, and surfaces non-404 download failures with host and endpoint context. Reading private files from a generic non-default host now requires a whole-repo git dependency or explicit backend signal; see the dependency and lockfile docs (closes #773). (#1735)

src/apm_cli/install/phases/targets.py

@@ -67,6 +67,24 @@ def _as_yaml_targets(value: str | list[str] | None) -> list[str] | None:
     return parts or None
 
 
+def _normalize_runtime_target_aliases(tokens: Iterable[str]) -> list[str]:
+    """Map runtime aliases to canonical target names in first-seen order."""
+    from apm_cli.integration.targets import RUNTIME_TO_CANONICAL_TARGET
+
+    normalized: list[str] = []
+    seen: set[str] = set()
+    for token in tokens:
+        raw = str(token).strip()
+        if not raw:
+            continue
+        canonical = RUNTIME_TO_CANONICAL_TARGET.get(raw, raw)
+        if canonical in seen:
+            continue
+        seen.add(canonical)
+        normalized.append(canonical)
+    return normalized
+
+
 def _read_yaml_targets(ctx) -> list[str] | None:
     """Read targets/target from raw apm.yml using v2 parser.
 
@@ -357,6 +375,8 @@ def _fmt_target(t: Any) -> str:
             parts = [t.strip() for t in raw_override.split(",") if t.strip()]
         else:
             parts = list(raw_override)
+        # Multi-token CLI parsing returns runtime aliases; convert them before filtering.
+        parts = _normalize_runtime_target_aliases(parts)
         parts = [p for p in parts if p in _CANONICAL]
         if len(parts) == 1:
             _v2_flag = parts[0]
@@ -551,9 +571,10 @@ def run_targets_phase(ctx) -> None:
         if isinstance(ctx.target_override, str):
             # Handle CSV form
             parts = [t.strip() for t in ctx.target_override.split(",") if t.strip()]
-            flag = parts if len(parts) > 1 else parts[0] if parts else None
         else:
-            flag = ctx.target_override
+            parts = list(ctx.target_override)
+        parts = _normalize_runtime_target_aliases(parts)
+        flag = parts if len(parts) > 1 else parts[0] if parts else None
 
     # Get yaml_targets from apm_package.
     try:

tests/unit/install/phases/test_targets_phase_v2.py

@@ -30,7 +30,7 @@
 def _make_ctx(
     project_root: Path,
     *,
-    target_override: str | None = None,
+    target_override: str | list[str] | None = None,
     yaml_target: str | None = None,
     yaml_targets: list[str] | None = None,
 ) -> MagicMock:
@@ -46,9 +46,15 @@ def _make_ctx(
     ctx.logger = MagicMock()
     ctx.targets = []
     ctx.integrators = {}
+    ctx.legacy_skill_paths = False
     return ctx
 
 
+def _target_names(ctx: MagicMock) -> list[str]:
+    """Return the resolved target profile names from a phase context."""
+    return [target.name for target in ctx.targets]
+
+
 def _target_root_dirs(ctx, project_root: Path) -> list[Path]:
     """Collect on-disk deploy directories for every TargetProfile in ctx.targets.
 
@@ -68,6 +74,97 @@ def _target_root_dirs(ctx, project_root: Path) -> list[Path]:
     return out
 
 
+def test_runtime_alias_list_preserves_copilot_profile_and_dirs(tmp_path: Path) -> None:
+    """Multi-target runtime aliases resolve through the copilot profile."""
+    from apm_cli.install.phases.targets import run
+
+    project = tmp_path / "project"
+    project.mkdir()
+
+    ctx = _make_ctx(project, target_override=["claude", "vscode"])
+    run(ctx)
+
+    assert _target_names(ctx) == ["claude", "copilot"]
+    assert (project / ".claude").is_dir()
+    assert (project / ".github").is_dir()
+
+
+@pytest.mark.parametrize("target_override", [["vscode"], "vscode"])
+def test_run_targets_phase_normalizes_vscode_alias(
+    tmp_path: Path,
+    target_override: str | list[str],
+) -> None:
+    """The v2 wrapper accepts vscode as the runtime alias for copilot."""
+    from apm_cli.install.phases.targets import run_targets_phase
+
+    project = tmp_path / "project"
+    project.mkdir()
+
+    ctx = _make_ctx(project, target_override=target_override)
+    run_targets_phase(ctx)
+
+    assert _target_names(ctx) == ["copilot"]
+    assert (project / ".github").is_dir()
+
+
+def test_cli_parse_claude_copilot_installs_both_targets(tmp_path: Path) -> None:
+    """Regression trap for #1746: --target claude,copilot resolves both targets.
+
+    parse_target_field intentionally returns the runtime alias spelling for
+    multi-token input ("copilot" -> "vscode"); the targets phase must then
+    normalize that alias back to the canonical "copilot" profile instead of
+    silently dropping it.
+    """
+    from apm_cli.core.target_detection import parse_target_field
+    from apm_cli.install.phases.targets import run
+
+    project = tmp_path / "project"
+    project.mkdir()
+
+    parsed = parse_target_field("claude,copilot")
+    ctx = _make_ctx(project, target_override=parsed)
+    run(ctx)
+
+    # Multi-token parsing yields the runtime alias, not the canonical name.
+    assert parsed == ["claude", "vscode"]
+    # The phase normalizes the alias so the copilot profile is preserved.
+    assert _target_names(ctx) == ["claude", "copilot"]
+    assert (project / ".claude").is_dir()
+    assert (project / ".github").is_dir()
+
+
+def test_run_targets_phase_dedupes_copilot_runtime_aliases(tmp_path: Path) -> None:
+    """Mixed canonical/runtime tokens collapse to one copilot profile."""
+    from apm_cli.install.phases.targets import run_targets_phase
+
+    project = tmp_path / "project"
+    project.mkdir()
+
+    ctx = _make_ctx(project, target_override=["copilot", "vscode"])
+    run_targets_phase(ctx)
+
+    assert _target_names(ctx) == ["copilot"]
+
+
+def test_experimental_target_override_skips_v2_resolver(tmp_path: Path) -> None:
+    """Non-canonical experimental targets stay on the legacy-only path."""
+    from apm_cli.install.phases.targets import _resolve_targets_by_scope
+    from apm_cli.integration.targets import KNOWN_TARGETS
+
+    project = tmp_path / "project"
+    project.mkdir()
+
+    ctx = _make_ctx(project, target_override="copilot-cowork")
+    targets = _resolve_targets_by_scope(
+        ctx,
+        [KNOWN_TARGETS["copilot-cowork"]],
+        "copilot-cowork",
+        False,
+    )
+
+    assert [target.name for target in targets] == ["copilot-cowork"]
+
+
 def test_three_guard_collapse_no_skip(tmp_path):
     """Auto-detected target is never silently skipped after resolution."""
     from apm_cli.install.phases.targets import run_targets_phase